From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ase5s-00011a-Dk for qemu-devel@nongnu.org; Tue, 19 Apr 2016 18:26:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ase5n-0007yE-Az for qemu-devel@nongnu.org; Tue, 19 Apr 2016 18:26:04 -0400 Received: from e32.co.us.ibm.com ([32.97.110.150]:59851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ase5n-0007y1-57 for qemu-devel@nongnu.org; Tue, 19 Apr 2016 18:25:59 -0400 Received: from localhost by e32.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 19 Apr 2016 16:25:56 -0600 Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by d03dlp02.boulder.ibm.com (Postfix) with ESMTP id 81EFB3E40030 for ; Tue, 19 Apr 2016 16:25:46 -0600 (MDT) Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u3JMPksT34996424 for ; Tue, 19 Apr 2016 15:25:46 -0700 Received: from d03av01.boulder.ibm.com (localhost [127.0.0.1]) by d03av01.boulder.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u3JMPk65026162 for ; Tue, 19 Apr 2016 16:25:46 -0600 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable From: Michael Roth In-Reply-To: References: <1461051553-14720-1-git-send-email-hongyang.yang@easystack.cn> <20160419220157.14340.80493@loki> Message-ID: <20160419222541.11723.23534@loki> Date: Tue, 19 Apr 2016 17:25:41 -0500 Subject: Re: [Qemu-devel] [PATCH] qemu-ga: do not run qga test when guest agent disabled List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Yang Hongyang , QEMU Developers , Gerd Hoffmann , "Michael S. Tsirkin" , Paolo Bonzini Quoting Peter Maydell (2016-04-19 17:08:03) > On 19 April 2016 at 23:01, Michael Roth wrote: > > Quoting Yang Hongyang (2016-04-19 02:39:13) > >> When configure with --disable-guest-agent, make check will fail with: > >> ERROR:tests/test-qga.c:74:fixture_setup: assertion failed (error =3D= =3D NULL): > >> Failed to execute child process "/home/xx/qemu/qemu-ga" (No such file= or > >> directory) (g-exec-error-quark, 8) > >> make: *** [check-tests/test-qga] Error 1 > >> > >> This check was commented out by bab47d9a75a. I think that was by > >> mistake, because the commit message of that commit didn't mention > >> this change. > >> > >> Signed-off-by: Yang Hongyang > >> Cc: Gerd Hoffmann > >> Cc: Michael S. Tsirkin > >> Cc: Michael Roth > >> Cc: Paolo Bonzini > > > > Thanks, applied to qga tree: > > https://github.com/mdroth/qemu/commits/qga > > > > As much as I'd like to get this fixed for 2.6, the net effect, thanks to > > the inadvertant commenting out of qga test case in bab47d9a75a, is that > > the qemu-ga unit test currently gets skipped during make check. Given > > RC3 is going to be tagged soon, and afaik is the last RC, I'm not > > sure I would consider this enough of a blocker to send a last-minute > > pull. > > > > Peter: if you think there's still a window to get this in let me know > > and I'll send the pull immediately. But for now I'll queue this for > > 2.7 and for stable. > = > Well, I'm not planning to tag RC3 til Thursday, so you have time > in that sense. Whether it's worth putting into RC3 I leave to > your judgement (it sounds like the only effect of not having it > is "there's a test case we could be running that we don't run" ?) Yes. Although the patch fixes a more serious build/make check issue with --disable-guest-agent, the inadvertant commenting in bab47d9a75a (which was probably to work around that bug) masks the build failures by unconditionally disabling the test. Since disabling the unit test is a late regression, I think it's probably worthwhile to try to fix as long as it isn't holding up the release. Will send a pull shortly. > = > thanks > -- PMM >=20