From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48020) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1asr2p-0007HR-0V for qemu-devel@nongnu.org; Wed, 20 Apr 2016 08:15:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1asr2o-0002RM-93 for qemu-devel@nongnu.org; Wed, 20 Apr 2016 08:15:46 -0400 Date: Wed, 20 Apr 2016 14:15:37 +0200 From: Kevin Wolf Message-ID: <20160420121537.GI6517@noname.str.redhat.com> References: <1461106788-14285-1-git-send-email-mreitz@redhat.com> <1461106788-14285-2-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461106788-14285-2-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.6 1/2] block/mirror: Revive dead yielding code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Jeff Cody , Fam Zheng Am 20.04.2016 um 00:59 hat Max Reitz geschrieben: > mirror_iteration() is supposed to wait if the current chunk is subject > to a still in-flight mirroring operation. However, it mixed checking > this conflict situation with checking the dirty status of a chunk. A > simplification for the latter condition (the first chunk encountered is > always dirty) led to neglecting the former: We just skip the first chunk > and thus never test whether it conflicts with an in-flight operation. > > To fix this, pull out the code which waits for in-flight operations on > the first chunk of the range to be mirrored to settle. > > Signed-off-by: Max Reitz Reviewed-by: Kevin Wolf