From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44432)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1at5Fs-0000yK-9j
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 23:26:13 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1at5Fp-000647-4K
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 23:26:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39195)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1at5Fo-000643-VI
	for qemu-devel@nongnu.org; Wed, 20 Apr 2016 23:26:09 -0400
Date: Thu, 21 Apr 2016 11:26:12 +0800
From: Fam Zheng <famz@redhat.com>
Message-ID: <20160421032612.GF24822@dhcp-14-234.nay.redhat.com>
References: <1461191272-17802-1-git-send-email-Janne.Karhunen@gmail.com>
	<20160421022237.GE24822@dhcp-14-234.nay.redhat.com>
	<CAE=NcrYs7LLxoh4yofm0uOTRR9y5vqE_z2qPiZSO-3Ayk4jk-w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAE=NcrYs7LLxoh4yofm0uOTRR9y5vqE_z2qPiZSO-3Ayk4jk-w@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual
 hardware version.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Janne Karhunen <janne.karhunen@gmail.com>
Cc: qemu-devel@nongnu.org

On Wed, 04/20 20:02, Janne Karhunen wrote:
> On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng <famz@redhat.com> wrote:
> 
> >> Replace hardcoded vmdk description file hardware version flag with
> >> a user definable version.
> >
> > Hi Janne,
> >
> > Since this is a new feature, please explain why this change is desired (i.e.
> > the necessity.)
> 
> See here what it controls for vmware:
> 
> https://kb.vmware.com/selfservice/microsites/search.do?languag
> e=en_US&cmd=displayKC&externalId=1003746
> 
> Seems that the vmware cluster I'm using is configured to eat vmdks
> with only certain virtual hardware versions specified as being
> supported, so this patch allows me to define that version. Besides
> that, I've read that to mean that it's a hint from me (as the vmdk
> author) to the cluster that this is the vmware virtual hardware
> version I have tested this vmdk to run with. It's actually relatively
> useful metadata as such.
> 
> In other words, without the patch not a single qemu-img generated vmdk
> is 'good' for the system I'm using.

Thanks for the explanation, please add this information into the commit message
in next submission and also fix the option code so I can ack your patch.

Fam