From: Fam Zheng <famz@redhat.com>
To: Janne Karhunen <janne.karhunen@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version.
Date: Thu, 21 Apr 2016 12:44:01 +0800 [thread overview]
Message-ID: <20160421044401.GG24822@dhcp-14-234.nay.redhat.com> (raw)
In-Reply-To: <CAE=NcrZfL9BYaJ11FTSn1CajYnyAQ5sKqZC+pqf1sLXOoWvedg@mail.gmail.com>
On Wed, 04/20 20:22, Janne Karhunen wrote:
> On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng <famz@redhat.com> wrote:
>
> > For backward compatibility reason, we shouldn't remove a pre-existing option
> > without solid justification and probably a grace period. I suggest adding the
> > hwversion option in addition, and document and check it as exclusive with the
> > compat6 flag.
>
> That's certainly doable and kind of makes sense, but I'm not entirely
> sure that compat6 flag makes any sense to begin with. Does it?
I don't know VMware products well enough to tell, but it has been available
since forever, therefore my suggestion is to just keep it which cannot hurt.
If we really want to get rid of it, we should start printing a warning message
to indicate using the flag is deprecated and remove it one or a few releases
later. IMO it's not really worth the effort.
Fam
next prev parent reply other threads:[~2016-04-21 4:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-20 22:27 [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version Janne Karhunen
2016-04-21 2:22 ` Fam Zheng
2016-04-21 3:02 ` Janne Karhunen
2016-04-21 3:26 ` Fam Zheng
2016-04-21 3:30 ` Janne Karhunen
2016-04-21 3:22 ` Janne Karhunen
2016-04-21 4:44 ` Fam Zheng [this message]
2016-04-22 15:23 ` Janne Karhunen
2016-04-25 0:45 ` Fam Zheng
-- strict thread matches above, loose matches on Subject: below --
2016-04-21 19:29 Janne Karhunen
2016-04-29 7:41 ` Fam Zheng
2016-05-02 11:30 ` Janne Karhunen
2016-05-03 0:49 ` Fam Zheng
2016-05-03 9:45 ` Janne Karhunen
2016-05-03 9:43 Janne Karhunen
2016-05-06 5:15 ` Janne Karhunen
2016-05-06 9:07 ` Fam Zheng
2016-05-06 9:04 ` Fam Zheng
2016-05-06 11:05 ` Kevin Wolf
2016-05-06 17:53 ` Janne Karhunen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421044401.GG24822@dhcp-14-234.nay.redhat.com \
--to=famz@redhat.com \
--cc=janne.karhunen@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).