From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54011) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at6TC-0002oN-2Y for qemu-devel@nongnu.org; Thu, 21 Apr 2016 00:44:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1at6T8-0005TL-NR for qemu-devel@nongnu.org; Thu, 21 Apr 2016 00:44:02 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45216) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1at6T8-0005T9-Ho for qemu-devel@nongnu.org; Thu, 21 Apr 2016 00:43:58 -0400 Date: Thu, 21 Apr 2016 12:44:01 +0800 From: Fam Zheng Message-ID: <20160421044401.GG24822@dhcp-14-234.nay.redhat.com> References: <1461191272-17802-1-git-send-email-Janne.Karhunen@gmail.com> <20160421022237.GE24822@dhcp-14-234.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Janne Karhunen Cc: qemu-devel@nongnu.org On Wed, 04/20 20:22, Janne Karhunen wrote: > On Wed, Apr 20, 2016 at 7:22 PM, Fam Zheng wrote: > > > For backward compatibility reason, we shouldn't remove a pre-existing option > > without solid justification and probably a grace period. I suggest adding the > > hwversion option in addition, and document and check it as exclusive with the > > compat6 flag. > > That's certainly doable and kind of makes sense, but I'm not entirely > sure that compat6 flag makes any sense to begin with. Does it? I don't know VMware products well enough to tell, but it has been available since forever, therefore my suggestion is to just keep it which cannot hurt. If we really want to get rid of it, we should start printing a warning message to indicate using the flag is deprecated and remove it one or a few releases later. IMO it's not really worth the effort. Fam