From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Gonglei (Arei)" <arei.gonglei@huawei.com>
Cc: "virtio-dev@lists.oasis-open.org"
<virtio-dev@lists.oasis-open.org>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
"Cornelia Huck" <cornelia.huck@de.ibm.com>,
"mst@redhat.com" <mst@redhat.com>,
"Huangpeng (Peter)" <peter.huangpeng@huawei.com>,
"Hanweidong (Randy)" <hanweidong@huawei.com>,
"Jani Kokkonen" <Jani.Kokkonen@huawei.com>,
"Zhoujian (jay, Euler)" <jianjay.zhou@huawei.com>,
"Lingli Deng" <denglingli@chinamobile.com>,
"Mihai Claudiu Caraman" <mike.caraman@nxp.com>,
"'Ola Liljedahl@arm.com'" <Ola.Liljedahl@arm.com>,
"Crasta Denis-B22176" <denis.crasta@freescale.com>,
"Varun Sethi" <Varun.Sethi@freescale.com>,
"'Venkatesan, Venky'" <venky.venkatesan@intel.com>,
"Catalin Vasile" <cata.vasile@nxp.com>,
"'François-Frédéric Ozog'" <ff.ozog@6wind.com>,
Luonengjun <luonengjun@huawei.com>
Subject: Re: [Qemu-devel] [RFC v3] virtio-crypto specification
Date: Thu, 21 Apr 2016 16:23:48 +0100 [thread overview]
Message-ID: <20160421152348.GC11814@stefanha-x1.localdomain> (raw)
In-Reply-To: <33183CC9F5247A488A2544077AF19020B03164A0@SZXEMA503-MBS.china.huawei.com>
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Tue, Apr 19, 2016 at 08:37:13AM +0000, Gonglei (Arei) wrote:
> 1.6.1.1 Driver Requirements: Session operation
> The driver MUST set the control type with VIRTIO_CRYPTO_CTRL_CREATE_SESSION before the request is preceded by an operation header when executing session creation:
Based on the text I guess you need the following to create a session:
struct session_create {
struct virtio_crypto_sym_ctlhdr ctlhdr; /* OUT */
struct virtio_crypto_sym_session_op session_op; /* OUT */
struct virtio_crypto_sym_session_op_inhdr inhdr; /* IN */
};
Please show the full C struct so the spec is clear on how to lay out the
request. The same applies for other operations.
> 1.6.2.1 Steps of encryption Operation
> Both controlq and dataq virtqueue are bidirectional.
Virtqueues are always "bidirectional" so this sentence doesn't mean
anything. It can be dropped.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-21 15:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 8:37 [Qemu-devel] [RFC v3] virtio-crypto specification Gonglei (Arei)
2016-04-19 14:23 ` Michael S. Tsirkin
2016-04-20 0:29 ` Gonglei (Arei)
2016-04-21 15:23 ` Stefan Hajnoczi [this message]
2016-04-22 0:28 ` Gonglei (Arei)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160421152348.GC11814@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=Jani.Kokkonen@huawei.com \
--cc=Ola.Liljedahl@arm.com \
--cc=Varun.Sethi@freescale.com \
--cc=arei.gonglei@huawei.com \
--cc=cata.vasile@nxp.com \
--cc=cornelia.huck@de.ibm.com \
--cc=denglingli@chinamobile.com \
--cc=denis.crasta@freescale.com \
--cc=ff.ozog@6wind.com \
--cc=hanweidong@huawei.com \
--cc=jianjay.zhou@huawei.com \
--cc=luonengjun@huawei.com \
--cc=mike.caraman@nxp.com \
--cc=mst@redhat.com \
--cc=peter.huangpeng@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=venky.venkatesan@intel.com \
--cc=virtio-dev@lists.oasis-open.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).