From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Jeff Cody <jcody@redhat.com>,
Max Reitz <mreitz@redhat.com>,
stefanha@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.6 2/3] mirror: Skip BH for mirror_exit if in main loop
Date: Fri, 22 Apr 2016 17:37:56 +0800 [thread overview]
Message-ID: <20160422093756.GB4437@ad.usersys.redhat.com> (raw)
In-Reply-To: <1461306907-2837-3-git-send-email-famz@redhat.com>
On Fri, 04/22 14:35, Fam Zheng wrote:
> As a bandage, this patch undoes the change of 5a7e7a0bad17 in
> non-dataplane case, and calls mirror_replace directly in mirror_run.
mirror_exit minus mirror_replace was kept in the BH because it's not safe to
call in coroutine. After discussing with kwolf on IRC, now it turns out that
mirror_replace isn't either, due to the bdrv_drain_all in bdrv_reopen. So,
NACK
The only feasible fix for 2.6 is with the previous direction, but we need
is_external check added to the main loop. Patches are being worked on.
Fam
next prev parent reply other threads:[~2016-04-22 9:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 6:35 [Qemu-devel] [PATCH for-2.6 0/3] block: Fix assertion failure at mirror exit Fam Zheng
2016-04-22 6:35 ` [Qemu-devel] [PATCH for-2.6 1/3] mirror: Extract mirror_replace Fam Zheng
2016-04-22 6:35 ` [Qemu-devel] [PATCH for-2.6 2/3] mirror: Skip BH for mirror_exit if in main loop Fam Zheng
2016-04-22 9:37 ` Fam Zheng [this message]
2016-04-22 6:35 ` [Qemu-devel] [PATCH for-2.6 3/3] block: Update comment of bdrv_drained_begin Fam Zheng
2016-04-22 6:46 ` [Qemu-devel] [PATCH for-2.6 0/3] block: Fix assertion failure at mirror exit Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422093756.GB4437@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).