From: Christoffer Dall <christoffer.dall@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
qemu-devel@nongnu.org, Marc Zyngier <marc.zyngier@arm.com>,
Alexander Graf <agraf@suse.de>
Subject: Re: [Qemu-devel] Performance regression using KVM/ARM
Date: Fri, 22 Apr 2016 12:02:00 +0200 [thread overview]
Message-ID: <20160422100200.GE25288@cbox> (raw)
In-Reply-To: <57194CEF.3040202@redhat.com>
Hi Laszlo,
On Thu, Apr 21, 2016 at 11:58:07PM +0200, Laszlo Ersek wrote:
> On 04/21/16 18:23, Christoffer Dall wrote:
> > Hi,
> >
> > Commit 9fac18f (oslib: allocate PROT_NONE pages on top of RAM,
> > 2015-09-10) had the unfortunate side effect that memory slots registered
> > with KVM no longer contain a userspace address that is aligned to a 2M
> > boundary, causing the use of THP to fail in the kernel.
> >
> > I fail to see where in the QEMU code we should be asking for a 2M
> > alignment of our memory region. Can someone help pointing me to the
> > right place to fix this or suggest a patch?
> >
> > This causes a performance regssion of hackbench on KVM/ARM of about 62%
> > compared to the workload running with THP.
> >
> > We have verified that this is indeed the cause of the failure by adding
> > various prints to QEMU and the kernel, but unfortunatley my QEMU
> > knowledge is not sufficient for me to fix it myself.
> >
> > Any help would be much appreciated!
>
> Can you please test the attached series?
>
> (Note that I'm only interested in solving this problem as a productive
> distraction, so if the patches don't work, or require a lot of massaging
> for merging, I'll just drop them (or, preferably, give them to someone
> else).)
>
I like your procrastination methods!
Unfortunately this fix wasn't the right one either.
-Christoffer
prev parent reply other threads:[~2016-04-22 10:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 16:23 [Qemu-devel] Performance regression using KVM/ARM Christoffer Dall
2016-04-21 19:50 ` Alexander Graf
2016-04-22 10:01 ` Christoffer Dall
2016-04-22 10:06 ` Alexander Graf
2016-04-22 10:15 ` Christoffer Dall
2016-04-22 10:17 ` Peter Maydell
2016-04-22 10:26 ` Christoffer Dall
2016-04-22 11:16 ` Andrew Jones
2016-04-22 11:24 ` Alexander Graf
2016-06-13 14:53 ` Auger Eric
2016-04-21 21:58 ` Laszlo Ersek
2016-04-22 10:02 ` Christoffer Dall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422100200.GE25288@cbox \
--to=christoffer.dall@linaro.org \
--cc=agraf@suse.de \
--cc=lersek@redhat.com \
--cc=marc.zyngier@arm.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).