From: Kevin Wolf <kwolf@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>,
John Ferlan <jferlan@redhat.com>,
Pino Toscano <ptoscano@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts
Date: Fri, 22 Apr 2016 12:59:28 +0200 [thread overview]
Message-ID: <20160422105928.GC4237@noname.redhat.com> (raw)
In-Reply-To: <1461320695-31372-2-git-send-email-berrange@redhat.com>
Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben:
> The iSCSI block driver has ability to lookup various options, in
> particular authentication info, specified by the separate -iscsi
> argument. It currently uses the iSCSI IQN as the ID value for this
> lookup, however, this does not work for common iSCSI IQNs as they
> contain characters such as ':' which are invalid for use as IDs.
>
> This adds an optional 'iscsi-id' parameter to the iSCSI block
> driver to allow an explicit ID string to be used to reference
> the -iscsi arg. For example
>
> $QEMU \
> -iscsi id=my_initiator,user=fred,password-secret=sec0 \
> -drive driver=iscsi,iscsi-id=my_initiator,file=iscsi://somehost/iqn/1
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
I would consider this a new feature rather than a fix appropriate for
-rc4.
Kevin
next prev parent reply other threads:[~2016-04-22 10:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 10:24 [Qemu-devel] [PATCH for-2.6] Fix association of -drive & -iscsi args Daniel P. Berrange
2016-04-22 10:24 ` [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts Daniel P. Berrange
2016-04-22 10:59 ` Kevin Wolf [this message]
2016-04-22 11:13 ` Peter Lieven
2016-04-22 11:43 ` Daniel P. Berrange
2016-04-22 11:53 ` Kevin Wolf
2016-04-22 11:55 ` Daniel P. Berrange
2016-04-22 12:10 ` Peter Maydell
2016-04-22 12:29 ` Daniel P. Berrange
2016-04-22 11:50 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422105928.GC4237@noname.redhat.com \
--to=kwolf@redhat.com \
--cc=berrange@redhat.com \
--cc=jferlan@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=ptoscano@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).