From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1atYoC-0004bZ-PL for qemu-devel@nongnu.org; Fri, 22 Apr 2016 06:59:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1atYoB-0006ZU-QJ for qemu-devel@nongnu.org; Fri, 22 Apr 2016 06:59:36 -0400 Date: Fri, 22 Apr 2016 12:59:28 +0200 From: Kevin Wolf Message-ID: <20160422105928.GC4237@noname.redhat.com> References: <1461320695-31372-1-git-send-email-berrange@redhat.com> <1461320695-31372-2-git-send-email-berrange@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461320695-31372-2-git-send-email-berrange@redhat.com> Subject: Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Ronnie Sahlberg , Paolo Bonzini , Peter Lieven , John Ferlan , Pino Toscano Am 22.04.2016 um 12:24 hat Daniel P. Berrange geschrieben: > The iSCSI block driver has ability to lookup various options, in > particular authentication info, specified by the separate -iscsi > argument. It currently uses the iSCSI IQN as the ID value for this > lookup, however, this does not work for common iSCSI IQNs as they > contain characters such as ':' which are invalid for use as IDs. > > This adds an optional 'iscsi-id' parameter to the iSCSI block > driver to allow an explicit ID string to be used to reference > the -iscsi arg. For example > > $QEMU \ > -iscsi id=my_initiator,user=fred,password-secret=sec0 \ > -drive driver=iscsi,iscsi-id=my_initiator,file=iscsi://somehost/iqn/1 > > Signed-off-by: Daniel P. Berrange I would consider this a new feature rather than a fix appropriate for -rc4. Kevin