From: "Daniel P. Berrange" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Kevin Wolf <kwolf@redhat.com>, Qemu-block <qemu-block@nongnu.org>,
Peter Lieven <pl@kamp.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Pino Toscano <ptoscano@redhat.com>,
Ronnie Sahlberg <ronniesahlberg@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
John Ferlan <jferlan@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts
Date: Fri, 22 Apr 2016 13:29:37 +0100 [thread overview]
Message-ID: <20160422122937.GH17478@redhat.com> (raw)
In-Reply-To: <CAFEAcA8Fr-Y75GhPPkZdKbOvwgj7zm-PocY5d2u8qXtdusQyvA@mail.gmail.com>
On Fri, Apr 22, 2016 at 01:10:40PM +0100, Peter Maydell wrote:
> On 22 April 2016 at 12:55, Daniel P. Berrange <berrange@redhat.com> wrote:
> > On Fri, Apr 22, 2016 at 01:53:47PM +0200, Kevin Wolf wrote:
> >> -iscsi is a weird thing anyway. We should do things the usual way, with
> >> a proper BlockdevOptionsIscsi QAPI structure. Introducing a new API in
> >> 2.6 when we know we'll deprecate it again in 2.7 doesn't seem to make
> >> that much sense.
> >>
> >> Plus, it's -rc4 now. The problem isn't a crash or a regression. It
> >> merely means that you might need to wait for another release before you
> >> can use iscsi. Pretty much the definition of a new feature.
> >
> > Ok, i thought that would probably be the response, but I wanted to be able
> > to say I tried anyway, given it was for a libvirt security bug. We'll just
> > have to a wait a bit longer to fix it for iscsi.
>
> OK, I have moved that item to "Not planned to be fixed for 2.6" in
> the Planning page. Could you write a suitable note in the ChangeLog
> page if you think it makes sense to do so, please?
Yep, will do.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-04-22 12:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 10:24 [Qemu-devel] [PATCH for-2.6] Fix association of -drive & -iscsi args Daniel P. Berrange
2016-04-22 10:24 ` [Qemu-devel] [PATCH for-2.6] block: add an 'iscsi-id' value to match -drive with -iscsi opts Daniel P. Berrange
2016-04-22 10:59 ` Kevin Wolf
2016-04-22 11:13 ` Peter Lieven
2016-04-22 11:43 ` Daniel P. Berrange
2016-04-22 11:53 ` Kevin Wolf
2016-04-22 11:55 ` Daniel P. Berrange
2016-04-22 12:10 ` Peter Maydell
2016-04-22 12:29 ` Daniel P. Berrange [this message]
2016-04-22 11:50 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422122937.GH17478@redhat.com \
--to=berrange@redhat.com \
--cc=jferlan@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=ptoscano@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=ronniesahlberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).