From: "Michael S. Tsirkin" <mst@redhat.com>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
Jeff Cody <jcody@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit
Date: Fri, 22 Apr 2016 17:00:00 +0300 [thread overview]
Message-ID: <20160422165952-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1461333236-5942-1-git-send-email-famz@redhat.com>
On Fri, Apr 22, 2016 at 09:53:51PM +0800, Fam Zheng wrote:
> v3: 04: Add check in aio_pending. [Kevin]
>
> I tested this series survives the "snapshot + commit" loop reproducer with both
> bonnie++ and RHEL installation in the guest.
>
> This supersedes the "virtio: Register host notifier handler as external" patch
> from yesterday.
>
> The bug was initially reported by Matthew Schumacher as LaunchPad Bug 1570134,
> and nicely bisected by Max Reitz. See patch 2 for the analysis.
Patches 1-3:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Fam Zheng (5):
> iohandler: Introduce iohandler_get_aio_context
> event-notifier: Add "is_external" parameter
> virtio: Mark host notifiers as external
> aio-posix: Skip external nodes in aio_dispatch
> mirror: Workaround for unexpected iohandler events during completion
>
> aio-posix.c | 8 ++++++--
> block/mirror.c | 9 +++++++++
> hw/usb/ccid-card-emulated.c | 2 +-
> hw/virtio/virtio.c | 8 ++++----
> include/qemu/event_notifier.h | 4 +++-
> include/qemu/main-loop.h | 1 +
> iohandler.c | 6 ++++++
> stubs/Makefile.objs | 1 +
> stubs/iohandler.c | 8 ++++++++
> stubs/set-fd-handler.c | 10 ++++++++++
> target-i386/hyperv.c | 6 +++---
> util/event_notifier-posix.c | 4 +++-
> util/event_notifier-win32.c | 1 +
> 13 files changed, 56 insertions(+), 12 deletions(-)
> create mode 100644 stubs/iohandler.c
>
> --
> 2.8.0
next prev parent reply other threads:[~2016-04-22 14:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-22 13:53 [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit Fam Zheng
2016-04-22 13:53 ` [Qemu-devel] [PATCH v3 for-2.6 1/5] iohandler: Introduce iohandler_get_aio_context Fam Zheng
2016-04-22 13:53 ` [Qemu-devel] [PATCH v3 for-2.6 2/5] event-notifier: Add "is_external" parameter Fam Zheng
2016-04-22 13:53 ` [Qemu-devel] [PATCH v3 for-2.6 3/5] virtio: Mark host notifiers as external Fam Zheng
[not found] ` <20160501111428-mutt-send-email-mst@redhat.com>
2016-05-01 9:55 ` Michael S. Tsirkin
2016-05-09 12:19 ` Paolo Bonzini
2016-04-22 13:53 ` [Qemu-devel] [PATCH v3 for-2.6 4/5] aio-posix: Skip external nodes in aio_dispatch Fam Zheng
2016-04-22 13:53 ` [Qemu-devel] [PATCH v3 for-2.6 5/5] mirror: Workaround for unexpected iohandler events during completion Fam Zheng
2016-04-22 14:00 ` Michael S. Tsirkin [this message]
2016-04-22 14:05 ` [Qemu-devel] [PATCH v3 for-2.6 0/5] block: Fix assertion failure at mirror exit Kevin Wolf
2016-04-22 14:13 ` Jeff Cody
2016-04-22 15:06 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160422165952-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).