From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auO6R-0006P5-Jc for qemu-devel@nongnu.org; Sun, 24 Apr 2016 13:45:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auO6O-00035g-Er for qemu-devel@nongnu.org; Sun, 24 Apr 2016 13:45:51 -0400 Received: from mail-wm0-x242.google.com ([2a00:1450:400c:c09::242]:34180) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auO6O-00035V-8S for qemu-devel@nongnu.org; Sun, 24 Apr 2016 13:45:48 -0400 Received: by mail-wm0-x242.google.com with SMTP id n3so19019648wmn.1 for ; Sun, 24 Apr 2016 10:45:46 -0700 (PDT) Date: Sun, 24 Apr 2016 19:45:34 +0200 From: Marc =?UTF-8?B?TWFyw60=?= Message-ID: <20160424194534.43b4424c@home> In-Reply-To: <1461330148-21393-2-git-send-email-rjones@redhat.com> References: <1461330148-21393-1-git-send-email-rjones@redhat.com> <1461330148-21393-2-git-send-email-rjones@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org, mst@redhat.com, ehabkost@redhat.com, rth@twiddle.net, pbonzini@redhat.com, stefanha@redhat.com, kraxel@redhat.com, lersek@redhat.com On Fri, 22 Apr 2016 14:02:28 +0100 "Richard W.M. Jones" wrote: > From: Marc Mar=C3=AD >=20 > This optionrom is based on linuxboot.S. >=20 > Signed-off-by: Marc Mar=C3=AD > Signed-off-by: Richard W.M. Jones > --- > .gitignore | 4 + > hw/i386/pc.c | 9 +- > hw/nvram/fw_cfg.c | 2 +- > include/hw/nvram/fw_cfg.h | 1 + > pc-bios/optionrom/Makefile | 13 +- > pc-bios/optionrom/linuxboot_dma.c | 305 > ++++++++++++++++++++++++++++++++++++++ 6 files changed, 329 > insertions(+), 5 deletions(-) create mode 100644 > pc-bios/optionrom/linuxboot_dma.c Thanks for picking this up and solving the issues! Reviewed-by: Marc Mar=C3=AD