From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auUem-0003ZY-4I for qemu-devel@nongnu.org; Sun, 24 Apr 2016 20:45:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auUei-0005E9-V3 for qemu-devel@nongnu.org; Sun, 24 Apr 2016 20:45:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38779) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auUei-0005E5-Pn for qemu-devel@nongnu.org; Sun, 24 Apr 2016 20:45:40 -0400 Date: Mon, 25 Apr 2016 08:45:44 +0800 From: Fam Zheng Message-ID: <20160425004544.GB18010@ad.usersys.redhat.com> References: <1461191272-17802-1-git-send-email-Janne.Karhunen@gmail.com> <20160421022237.GE24822@dhcp-14-234.nay.redhat.com> <20160421044401.GG24822@dhcp-14-234.nay.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] Allow users to specify the vmdk virtual hardware version. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Janne Karhunen Cc: qemu-devel@nongnu.org On Fri, 04/22 08:23, Janne Karhunen wrote: > On Wed, Apr 20, 2016 at 9:44 PM, Fam Zheng wrote: > > >> That's certainly doable and kind of makes sense, but I'm not entirely > >> sure that compat6 flag makes any sense to begin with. Does it? > > > > I don't know VMware products well enough to tell, but it has been available > > since forever, therefore my suggestion is to just keep it which cannot hurt. > > I sent the new patch yesterday with this option still present and it > works the same as it always has. I also tested it to work on all > option pairings, so it should be good to go AFAIK. Hope you have some > time to check that. Thanks for letting me know! I'll take a look soon. (Patches without correctly Cc'ing maintainers are very easy to get neglected. Please remember to use ./scripts/get_maintainer.pl (or ./MAINTAINERS) next time.) Fam