qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Isaac Lozano <109lozanoi@gmail.com>
Cc: qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain
Date: Tue, 26 Apr 2016 10:11:56 +0100	[thread overview]
Message-ID: <20160426091156.GA10650@stefanha-x1.localdomain> (raw)
In-Reply-To: <1460892593-5908-1-git-send-email-109lozanoi@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 996 bytes --]

On Sun, Apr 17, 2016 at 04:29:53AM -0700, Isaac Lozano wrote:
> If an application uses libmtp on the guest system,
> it will complain with the warning message:
> LIBMTP WARNING: VendorExtensionID: ffffffff
> LIBMTP WARNING: VendorExtensionDesc: (null)
> LIBMTP WARNING: this typically means the device is PTP (i.e. a camera) but
> not a MTP device at all. Trying to continue anyway.
> 
> This is because libmtp expects a MTP Vendor Extension ID of 0x00000006 and a
> MTP Version of 0x0064. These numbers are taken from Microsoft's MTP Vendor
> Extension Identification Message page and are what most physical devices
> show.
> 
> Signed-off-by: Isaac Lozano <109lozanoi@gmail.com>
> ---
>  hw/usb/dev-mtp.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Welcome to QEMU!

Link to MTP Vendor Extension Identification Message page for other
reviewers:
https://msdn.microsoft.com/en-us/library/ff632482.aspx

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

  reply	other threads:[~2016-04-26  9:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-17 11:29 [Qemu-devel] [PATCH] usb-mtp: fix usb_mtp_get_device_info so that libmtp on the guest doesn't complain Isaac Lozano
2016-04-26  9:11 ` Stefan Hajnoczi [this message]
2016-04-26 21:28   ` Bandan Das
2016-05-11  8:34 ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160426091156.GA10650@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=109lozanoi@gmail.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).