From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60923) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auz8E-0007f7-Og for qemu-devel@nongnu.org; Tue, 26 Apr 2016 05:18:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auz8A-0001no-On for qemu-devel@nongnu.org; Tue, 26 Apr 2016 05:18:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auz8A-0001nT-Jk for qemu-devel@nongnu.org; Tue, 26 Apr 2016 05:18:06 -0400 Date: Tue, 26 Apr 2016 10:18:03 +0100 From: "Richard W.M. Jones" Message-ID: <20160426091803.GR11600@redhat.com> References: <1461330148-21393-1-git-send-email-rjones@redhat.com> <1461656589.20704.8.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461656589.20704.8.camel@redhat.com> Subject: Re: [Qemu-devel] [PATCH v5] Add optionrom compatible with fw_cfg DMA version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org, mst@redhat.com, ehabkost@redhat.com, rth@twiddle.net, pbonzini@redhat.com, marc.mari.barcelo@gmail.com, stefanha@redhat.com, lersek@redhat.com On Tue, Apr 26, 2016 at 09:43:09AM +0200, Gerd Hoffmann wrote: > On Fr, 2016-04-22 at 14:02 +0100, Richard W.M. Jones wrote: > > v4 -> v5: > > > > * Fix the initrd loading problem by fixing the get_e801_addr > > function so it really reads the values from the BIOS. > > > > Previously the function always returned 16MB, and so it only happened > > to work for initrd sizes < ~15MB, and broke for anything larger. Now > > the function is fixed, I tested it on 20MB & 350KB initrds and it > > worked for both. > > Can confirm it works, and with a big initramfs it is a very noticable > speedup. > > > * Fix the Win32 cross-compiler issue by making the 'ld -m' (emulator) > > option conditional on CONFIG_WIN32. > > > > This change was not tested with the cross-compiler. Gerd, could you > > see if this fixes things? > > Yes, it builds fine now. > > Only thing I've noticed is that I have to manually copy the rom to > pc-bios/, I guess we want place a pre-compiled binary there like we do > for the other option roms. Yes, I noticed this too (on Linux non-cross-compiles). Not sure if that's right or wrong. Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org