From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auzm2-00075T-6S for qemu-devel@nongnu.org; Tue, 26 Apr 2016 05:59:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auzly-0003sJ-2l for qemu-devel@nongnu.org; Tue, 26 Apr 2016 05:59:18 -0400 Received: from mail-wm0-x234.google.com ([2a00:1450:400c:c09::234]:37265) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auzlx-0003s6-Sd for qemu-devel@nongnu.org; Tue, 26 Apr 2016 05:59:14 -0400 Received: by mail-wm0-x234.google.com with SMTP id n3so675089wmn.0 for ; Tue, 26 Apr 2016 02:59:13 -0700 (PDT) Date: Tue, 26 Apr 2016 10:59:11 +0100 From: Stefan Hajnoczi Message-ID: <20160426095911.GG10650@stefanha-x1.localdomain> References: <1461600281-23048-1-git-send-email-rjones@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="5L6AZ1aJH5mDrqCQ" Content-Disposition: inline In-Reply-To: <1461600281-23048-1-git-send-email-rjones@redhat.com> Subject: Re: [Qemu-devel] [PATCH v6] Add optionrom compatible with fw_cfg DMA version List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Richard W.M. Jones" Cc: qemu-devel@nongnu.org, marc.mari.barcelo@gmail.com, ehabkost@redhat.com, mst@redhat.com, kraxel@redhat.com, stefanha@redhat.com, pbonzini@redhat.com, lersek@redhat.com, rth@twiddle.net --5L6AZ1aJH5mDrqCQ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 25, 2016 at 05:04:40PM +0100, Richard W.M. Jones wrote: > v5 -> v6: >=20 > - Changed the xen_load_linux assertion as suggested by Stefan. >=20 > - I renamed the variables in get_e801_addr function, since the > registers were really (16 bit 8086-style) AX, not EAX etc. Also I > changed the GCC asm to make it a little bit more efficient. I > verified by disassembling the function that GCC is still generating > the right code after this change. >=20 > - Re-tested with small (342K) libguestfs initramfs and with large > (20M) Fedora initramfs, and works fine in both cases. >=20 > Rich. >=20 >=20 Reviewed-by: Stefan Hajnoczi --5L6AZ1aJH5mDrqCQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXHzvvAAoJEJykq7OBq3PIufsH/iC73SiIQ/OlnY7UnqCAJIFP CbiqqVXVb9AQthNkyDbYIQR4M0PSMvQCjUrVMujJoPl+pmw3NhDi5iXe4+wGtjES +xTovYuG5rEddE25tq0/xBjugaFLs/HM+B7k/kbMvcTZDqJ5Ine8Ix3ruRZU5bzf jUrbuxRX86HJtrE8adO7OZMB6StHhGpeUXmo1ONVY89NbootPP4/nZh4HKGElC+u g2gC1QqpH1H2Tgiy2PG4mNzqN77v5GOnFOfLD0qPylcaKc+aF+TAjEr/30dQQmLy 8ZsF+NxeVN4i/DastO1eU2kZVKAzb8YpvUK1v8BaXMxdCQTxNIsT3fYGvDPXhB8= =qH2D -----END PGP SIGNATURE----- --5L6AZ1aJH5mDrqCQ--