From: Max Filippov <jcmvbkbc@gmail.com>
To: Zhou Jie <zhoujie2011@cn.fujitsu.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap
Date: Wed, 27 Apr 2016 05:46:26 +0300 [thread overview]
Message-ID: <20160427024626.GB17756@octofox.metropolis> (raw)
In-Reply-To: <57202190.9070106@cn.fujitsu.com>
Hi Zhou,
On Wed, Apr 27, 2016 at 10:18:56AM +0800, Zhou Jie wrote:
> When I committed another patch which named as
> "hw/net/virtio-net: Allocating Large sized arrays to heap" .
>
> Christian Borntraeger said that 16k is usually perfectly fine
> for a userspace stack and doing allocations in a hot path
> might actually hurt performance.
>
> Although the size is 65536 bytes here,
> I think open_eth_start_xmit is in a hot path.
> So, it is OK, if you think that this patch should not be applied.
With Linux as guest OS we shouldn't see any allocations
as it doesn't send huge packets, so I think this patch is fine.
I can take it through the xtensa tree if you don't have other
plan.
--
Thanks.
-- Max
next prev parent reply other threads:[~2016-04-27 2:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 2:07 [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap Zhou Jie
2016-04-27 2:18 ` Zhou Jie
2016-04-27 2:46 ` Max Filippov [this message]
2016-04-27 2:51 ` Zhou Jie
2016-04-27 2:37 ` Max Filippov
2016-04-27 3:27 ` Wei, Jiangang
2016-04-27 3:44 ` Max Filippov
2016-04-27 3:48 ` Wei, Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427024626.GB17756@octofox.metropolis \
--to=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=zhoujie2011@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).