From: Max Filippov <jcmvbkbc@gmail.com>
To: "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>
Cc: "Zhou, Jie" <zhoujie2011@cn.fujitsu.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap
Date: Wed, 27 Apr 2016 06:44:03 +0300 [thread overview]
Message-ID: <20160427034403.GA19255@octofox.metropolis> (raw)
In-Reply-To: <1461727665.1966.10.camel@localhost>
Hi Wei,
On Wed, Apr 27, 2016 at 03:27:47AM +0000, Wei, Jiangang wrote:
> On Wed, 2016-04-27 at 10:07 +0800, Zhou Jie wrote:
> > static void open_eth_start_xmit(OpenEthState *s, desc *tx)
> > {
> > - uint8_t buf[65536];
> > + uint8_t *buf = NULL;
> > + uint8_t buffer[0x600];
> Hi,
>
> I'm curious about 0x600.
> How do you determine this size?
> IMO, Max's suggestion looks more reasonable.
> (1536 bytes, maximal frame length when HUGEN bit is not set in MODER)
This is the same value. Opencores 10/100 ethernet spec uses both
decimal and hexadecimal notation.
--
Thanks.
-- Max
next prev parent reply other threads:[~2016-04-27 3:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-27 2:07 [Qemu-devel] [PATCH v2] hw/net/opencores_eth: Allocating Large sized arrays to heap Zhou Jie
2016-04-27 2:18 ` Zhou Jie
2016-04-27 2:46 ` Max Filippov
2016-04-27 2:51 ` Zhou Jie
2016-04-27 2:37 ` Max Filippov
2016-04-27 3:27 ` Wei, Jiangang
2016-04-27 3:44 ` Max Filippov [this message]
2016-04-27 3:48 ` Wei, Jiangang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160427034403.GA19255@octofox.metropolis \
--to=jcmvbkbc@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=weijg.fnst@cn.fujitsu.com \
--cc=zhoujie2011@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).