From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51023) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avIqV-0008Up-8J for qemu-devel@nongnu.org; Wed, 27 Apr 2016 02:21:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avIqU-0005YP-7l for qemu-devel@nongnu.org; Wed, 27 Apr 2016 02:21:11 -0400 Date: Wed, 27 Apr 2016 16:22:25 +1000 From: David Gibson Message-ID: <20160427062225.GE18476@voom.redhat.com> References: <1461119601-4936-1-git-send-email-david@gibson.dropbear.id.au> <1461119601-4936-12-git-send-email-david@gibson.dropbear.id.au> <571865B5.6000209@ozlabs.ru> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KuLpqunXa7jZSBt+" Content-Disposition: inline In-Reply-To: <571865B5.6000209@ozlabs.ru> Subject: Re: [Qemu-devel] [RFC for-2.7 11/11] pseries: Remove unused callbacks from sPAPR VIO bus state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: agraf@suse.de, crosthwaite.peter@gmail.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org --KuLpqunXa7jZSBt+ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 21, 2016 at 03:31:33PM +1000, Alexey Kardashevskiy wrote: > On 04/20/2016 12:33 PM, David Gibson wrote: > >The VIOsPAPRBus structure has some callback pointers in it which aren't > >used anywhere in the code. It's not clear exactly why they were there in > >the first place, but they certainly have no function now. >=20 > It is clear - incorrect QOM'fication in 3954d33ab7f82f5a5 when parts of > VIOsPAPRDeviceInfo became parts of VIOsPAPRBus, you can adjust the commit > log :) Thanks for the research, I'll update accordingly. --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --KuLpqunXa7jZSBt+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIbBAEBAgAGBQJXIFqhAAoJEGw4ysog2bOS2KUP9jFonWd5z0GO33MpWkenIffz KLYb92PCid4U5URVZdhcoxxdJk5rPT3rjYc6+yOg+jn3cTOfZxUi4vvnEUJryEdL MUsw/9Z04Ou77PD7Eeu3ZniuGwBN7DqYQJd1tjjbNPPqZqbIcBv9GS3049FUOTxm EqGu6k6MUaWGX/Wt9jvI5m+fs/jwxti4t0wIqTXOvmHH2fyFrrDnatt4aakWydMb XnWZBIMza2oDTL+UdXpiJA8POnam7OXcN5G235JqEEqOXo/kUFC2A3sJHe+msX/e UCSpM8b/hgRBmRhu9BrKG/yiJIvJk+sEjLEv2OZFqoXIusQZNVpt2ABag7y3UUBJ kHhPKGCnFEIX1oQo4aiwgHHk/QY9FThU5iDDMWkrs6RxnMzs8wDA8LKglJmihAsn YbI1NKiYYb/YvExW2rwt9xcEa3dLWL0CIcudepP8P7RmxBmlgtUd7WvFwc0JaNw3 YG9dHEpb4xgiDGV+vEc1LjngU0FnGLNNZNA4uPzZaH+1kpJfY5nZJsY8hQRwrJtn VZagjtE8/dMOyw7YaFDDH6TmORgEZcEVpX+RYPhSw0IQMM3DoSXYmjUl7n9YLUue KvfzN5evBOV9sK2tnFVzOmVo0ACZxQzGE6Ctwbyg5XUlVacRQbbRlnXdsvVHmq5x uecmrEtqBWC61QsMCCI= =HHRU -----END PGP SIGNATURE----- --KuLpqunXa7jZSBt+--