From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38588)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1avQZi-0007Fu-Jf
	for qemu-devel@nongnu.org; Wed, 27 Apr 2016 10:36:23 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1avQZh-0006uy-Rl
	for qemu-devel@nongnu.org; Wed, 27 Apr 2016 10:36:22 -0400
Date: Wed, 27 Apr 2016 16:36:12 +0200
From: Kevin Wolf <kwolf@redhat.com>
Message-ID: <20160427143612.GD4756@noname.str.redhat.com>
References: <1461750767-23273-1-git-send-email-kwolf@redhat.com>
	<1461750767-23273-11-git-send-email-kwolf@redhat.com>
	<20160427141717.GH1985@stefanha-x1.localdomain>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="9zSXsLTf0vkW971A"
Content-Disposition: inline
In-Reply-To: <20160427141717.GH1985@stefanha-x1.localdomain>
Subject: Re: [Qemu-devel] [PATCH 10/17] vdi: Implement .bdrv_co_pwritev()
 interface
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-block@nongnu.org, mreitz@redhat.com, famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org


--9zSXsLTf0vkW971A
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Am 27.04.2016 um 16:17 hat Stefan Hajnoczi geschrieben:
> On Wed, Apr 27, 2016 at 11:52:40AM +0200, Kevin Wolf wrote:
> > @@ -703,6 +712,7 @@ static int vdi_co_write(BlockDriverState *bs,
> >          VdiHeader *header =3D (VdiHeader *) block;
> >          uint8_t *base;
> >          uint64_t offset;
> > +        uint32_t n_sectors;
> > =20
> >          logout("now writing modified header\n");
> >          assert(VDI_IS_ALLOCATED(bmap_first));
>=20
> Unnecessary change?

No, I removed a top-level n_sectors declaration because I wanted the
compiler to complain about any uses in the main part, which should be
byte-aligned now. This final block still uses some sector arithmetics,
though, and therefore needs to reintroduce the variable.

Kevin

--9zSXsLTf0vkW971A
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)

iQIcBAEBAgAGBQJXIM5cAAoJEH8JsnLIjy/W098P/RtE4pdCCJ7fsJjzqNVmgFKF
uP7V3dikNqP6VXxwCtbrfMKPf0s2mp2uVOlckFgYcAL056DTP+V04eW3T2O/bBVo
RPfmDMP1yckJ5RosTzQH0WrQFhtP8l1hu/okByG7NtVX3gGkB1nboWx+ZanI4OkP
crSU4tRIB88952G/LcEAcMRzo8qKAyUvdrTwNWrf5Bpxcd3XDJj/KF9kZF8wTn4O
WdoI3x8ti2CusRh2n8hVybxUH7OWCYJsTlXJ/yztKyUaHfHNgqkZfkwc26FHYkRK
JMVXw4CWYiywwHtp23qAQgRMe77UulYVfnUnAHPeRlPwvpaMIF7Cie/ais9nbs6l
bHh2sfXjkt6Aa2jatHTHwCeFkPUuWJjCsDZIrCy+b5AZ66mn++szWYZcYPLTFJt3
EreVzM++UvRm6GhSDuegs0rfRDHBt0skB9upSShMlTq5U25C5mTvT7oSz/7TtSUq
VvMpgjUlGiTXAu3FoTJ94vIEhg5/27pUPm908UMB+a23RTNat7+MV1RLO4l2n0YK
LocN9m3tfb9LmepkD1/JLWKoxa5SlCsYlfLH9F4kC3FuyUEvE3GYdCyV+MPWcYzf
M0tmVVBKTgVCDM0jo424zB15xCbdjvQgDZb56EZfoca/eK6rZEIL8XMVLX76zOIq
a19sgVZHh6YMrheavIhT
=2vJC
-----END PGP SIGNATURE-----

--9zSXsLTf0vkW971A--