From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avQe8-0007Qr-Aw for qemu-devel@nongnu.org; Wed, 27 Apr 2016 10:41:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avQe5-0008L6-13 for qemu-devel@nongnu.org; Wed, 27 Apr 2016 10:40:56 -0400 Date: Wed, 27 Apr 2016 16:40:47 +0200 From: Kevin Wolf Message-ID: <20160427144047.GE4756@noname.str.redhat.com> References: <1461750767-23273-1-git-send-email-kwolf@redhat.com> <1461750767-23273-5-git-send-email-kwolf@redhat.com> <5720CDFF.6090702@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="1SQmhf2mF2YjsYvc" Content-Disposition: inline In-Reply-To: <5720CDFF.6090702@redhat.com> Subject: Re: [Qemu-devel] [PATCH 04/17] block: Rename bdrv_co_do_preadv/writev to bdrv_co_preadv/writev List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com --1SQmhf2mF2YjsYvc Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 27.04.2016 um 16:34 hat Eric Blake geschrieben: > On 04/27/2016 03:52 AM, Kevin Wolf wrote: > > It used to be an internal helper function just for implementing > > bdrv_co_do_readv/writev(), but now that it's a public interface, it > > deserves a name without "do" in it. > >=20 > > Signed-off-by: Kevin Wolf > > +++ b/hw/ide/macio.c > > @@ -55,8 +55,8 @@ static const int debug_macio =3D 0; > > /* > > * Unaligned DMA read/write access functions required for OS X/Darwin = which > > * don't perform DMA transactions on sector boundaries. These function= s are > > - * modelled on bdrv_co_do_preadv()/bdrv_co_do_pwritev() and so should = be > > - * easy to remove if the unaligned block APIs are ever exposed. > > + * modelled on bdrv_co_preadv()/bdrv_co_pwritev() and so should be eas= y to > > + * remove if the unaligned block APIs are ever exposed. > > */ >=20 > Is this comment now stale as a result of your series? No, as I mentioned in the cover letter, bdrv_co_preadv() and bdrv_co_pwritev() still enforce a minimum alignment of 512. The next steps towards using unaligned I/O in macio.c are removing that minimum (which we can now do for all drivers that implement =2Ebdrv_co_preadv/pwritev) and then using these functions in dma-helpers.c. Kevin --1SQmhf2mF2YjsYvc Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXIM9vAAoJEH8JsnLIjy/WbfYP/RvYsk7HF27GTEfBnJ34Tufs u1IlCvhM86740DuPzx8kzxxITePZu3N4tCnIF47BOjtS8nh0VbUITvhL5mYJ8biz p1Ii5fVzPusrSyd04QDKHf63bGtjdKvMmGYkipTtlz8sQzgSdlpacMT5KBXKhneB XC/hiUbKy0lAWJvadeg79wyu2Ts1fvNVRf3eSX9PBmlEVtm2uhRfMypRtEUzZSLP +VBt4oUMk40X68AyhC8IYf7B+0SiStVLNvrFjtxG9LzY367Hed7qrgIQbAVYkKgj btVo19zzNK518kVbjT6TnMoN/juotvWaamAZu3RLMYW1fcQ5drDVWik/LSSPJzGP yYzqdv9sj61WazPceVsbaAXrJourTwDDyRJXrrUy1A1s0v3bHeQtKaCpggfjpNhs TqqySWaltPIWzSe6Fwc75c74GbK7p2s+/bP9Z7hQMcQymbnAaGhZbm8kTDsdo6eU bYWLtec0YRC/z1M3ceq2BpW0m+MBc1BfsWZOi64cM84fPuXI6doagAUGXyoZji68 SbcU963jAOIMZCeE2HAx/DIkx4TznWXKZklkvQX9Ij0D+IzJa1sMICz8yv3wwG0K qFehiHr7Bjt1okNvM54nO38THpF+/mxnan7qh+t+3d+Z6VtpzchV2H/SFUZbFKiY oCqbp/lGVpHYw0sLko5G =uoaI -----END PGP SIGNATURE----- --1SQmhf2mF2YjsYvc--