From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avhCa-0002SL-6v for qemu-devel@nongnu.org; Thu, 28 Apr 2016 04:21:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avhCZ-0000DZ-9G for qemu-devel@nongnu.org; Thu, 28 Apr 2016 04:21:36 -0400 Date: Thu, 28 Apr 2016 10:21:22 +0200 From: Kevin Wolf Message-ID: <20160428082122.GA4474@noname.redhat.com> References: <1461750767-23273-1-git-send-email-kwolf@redhat.com> <1461750767-23273-7-git-send-email-kwolf@redhat.com> <5720E01A.1010909@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ikeVEW9yuYc//A+q" Content-Disposition: inline In-Reply-To: <5720E01A.1010909@redhat.com> Subject: Re: [Qemu-devel] [PATCH 06/17] bochs: Implement .bdrv_co_preadv() interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-block@nongnu.org, famz@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com --ikeVEW9yuYc//A+q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 27.04.2016 um 17:51 hat Eric Blake geschrieben: > On 04/27/2016 03:52 AM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > block/bochs.c | 46 +++++++++++++++++++++++++++++----------------- > > 1 file changed, 29 insertions(+), 17 deletions(-) > >=20 >=20 > > static void bochs_close(BlockDriverState *bs) > > @@ -267,7 +279,7 @@ static BlockDriver bdrv_bochs =3D { > > .instance_size =3D sizeof(BDRVBochsState), > > .bdrv_probe =3D bochs_probe, > > .bdrv_open =3D bochs_open, > > - .bdrv_read =3D bochs_co_read, > > + .bdrv_co_preadv =3D bochs_co_preadv, > > .bdrv_close =3D bochs_close, > > }; >=20 > Alignment is funky here. I'd rather just get rid of all the extra > spaces, if that's easier than having half but not all of the =3D aligned. Alignment is funky by definition when there are tabs involved and new code follows the coding style and uses spaces instead. With a tab stop of 4, this is aligned correctly. The other option would be to just convert the whole struct to spaces, but that's not really related to this patch and I think we're avoiding pure style cleanup patches to keep things like 'git blame' useful. Kevin --ikeVEW9yuYc//A+q Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXIcgCAAoJEH8JsnLIjy/WtvUP/0vrhCTmKE1C6TcYrg75gc3O 9JOIXUWLdcn+4ihJiCSMwoiHEmyDiPpFUs+i3KqH0m/fklTVPuOGk9h9dkpB4Ydq vNeMPM/Q96k0EDmxusQCbrY9GjUDd2293Gku2pEJeyVkH8ZDXJ5wCtwBMmHkHr++ roBCacgJ1VunOFy9Kr04SbqvMRTUMGGQVn52xTbpe7nO+ngD7Mw5cr7OzAiueYjS kn8xE2Ve1JrU5z1vpfOkJTQKQ4wx/j6QssjJ1qgkIr7rZh09zesk7IrXXZt2osiH CcFItLpccp2VRiMuZhtct+HiF/lRdSLrGaLlr/rnP4lyAcHoCjjrDoIyb3X2LksP XUZQMkZNyrfZC0QZeLoWAGi0Xx+0aQZWzQZZz471Eu+HQSRr6LNzNf6xDLLTCXI5 Y16LCG5i5KzWeAb2sxO2x8fr6RE706daaQbJu7wpkuhZFQZw6m/EVQVT2ThtyQPi TY+Iht42vPqyeK7I4nhfK/tbz2yP4tVTuVxrBBRo6e/cGF4LJYv9D6JdhNPmgbrU eBOYWPyZvFAP94116Tk4zUqzJfDkj5TZBj5X6RqZMBTjey4kRdC870jVMzS8Vwro q3fT+2sp7nwafpUWzD6uj+re6aSl8uq+NeN8dcMOuk41NQ20pOvc0yhfNXefDLeH d8Wf1OWZSHU+/W5oo8C5 =jiZs -----END PGP SIGNATURE----- --ikeVEW9yuYc//A+q--