From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48258)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1avyP1-0003p9-JC
	for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:43:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1avyOy-0001yd-BR
	for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:43:35 -0400
Received: from mx1.redhat.com ([209.132.183.28]:48183)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <peterx@redhat.com>) id 1avyOy-0001yT-6Q
	for qemu-devel@nongnu.org; Thu, 28 Apr 2016 22:43:32 -0400
Date: Fri, 29 Apr 2016 10:43:25 +0800
From: Peter Xu <peterx@redhat.com>
Message-ID: <20160429024325.GI20143@pxdev.xzpeter.org>
References: <1461827144-6937-1-git-send-email-peterx@redhat.com>
	<1461827144-6937-16-git-send-email-peterx@redhat.com>
	<5721BB09.2030302@web.de>
	<20160428082915.GF20143@pxdev.xzpeter.org>
	<5721CB83.4080005@web.de>
	<20160428084949.GG20143@pxdev.xzpeter.org>
	<CABdVeAB=5FWQ90=uPsoanvqiojkxrw-3DQgyOLYcYBNOKjHt2g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CABdVeAB=5FWQ90=uPsoanvqiojkxrw-3DQgyOLYcYBNOKjHt2g@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH v5 15/18] intel_iommu: introduce IEC
 notifiers
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Kiarie <davidkiarie4@gmail.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, QEMU Developers <qemu-devel@nongnu.org>, imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com, jasowang@redhat.com, Marcel Apfelbaum <marcel@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, pbonzini@redhat.com, rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com

On Thu, Apr 28, 2016 at 06:56:05PM +0300, David Kiarie wrote:

[...]

> I think AMD IOMMU could be a benefit greatly from the Intel IOMMU
> cache implementation. There could be a few differences but I think
> much of the code could be reused. The thing is, AMD IOMMU spec doesn't
> mention anything to do with it's cache design except the available
> interface (for system programmers) and I have a bit of a hard time
> trying to design a cache from scratch. Trying to do this will however
> require me to dig too much into Intel IOMMU and I would prefer to
> reserve that for later, probably.

Sure. I will not touch that part in this series. My first step would
be trying to remove vtd_* stuffs in common codes only, as Jan has
suggested.

Thanks,

-- peterx