From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53683) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1avysV-0005sQ-Ks for qemu-devel@nongnu.org; Thu, 28 Apr 2016 23:14:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1avysU-0001M9-R4 for qemu-devel@nongnu.org; Thu, 28 Apr 2016 23:14:03 -0400 Date: Fri, 29 Apr 2016 11:14:00 +0800 From: Fam Zheng Message-ID: <20160429031400.GF1421@ad.usersys.redhat.com> References: <1461849406-29743-1-git-send-email-kwolf@redhat.com> <1461849406-29743-15-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1461849406-29743-15-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 14/17] vpc: Implement .bdrv_co_preadv() interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-block@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, sw@weilnetz.de, qemu-devel@nongnu.org On Thu, 04/28 15:16, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > block/vpc.c | 79 ++++++++++++++++++++++++++++++++----------------------------- > 1 file changed, 42 insertions(+), 37 deletions(-) > > diff --git a/block/vpc.c b/block/vpc.c > index 3e2ea69..0099a80 100644 > --- a/block/vpc.c > +++ b/block/vpc.c > @@ -454,22 +454,21 @@ static int vpc_reopen_prepare(BDRVReopenState *state, > * The parameter write must be 1 if the offset will be used for a write > * operation (the block bitmaps is updated then), 0 otherwise. > */ > -static inline int64_t get_sector_offset(BlockDriverState *bs, > - int64_t sector_num, int write) > +static inline int64_t get_image_offset(BlockDriverState *bs, uint64_t offset, > + bool write) Parameter's indentation is one column off.