From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43021) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw3oC-0004Rw-Hy for qemu-devel@nongnu.org; Fri, 29 Apr 2016 04:30:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw3o2-0001jd-Jr for qemu-devel@nongnu.org; Fri, 29 Apr 2016 04:29:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw3o2-0001iC-Eb for qemu-devel@nongnu.org; Fri, 29 Apr 2016 04:29:46 -0400 Date: Fri, 29 Apr 2016 09:29:33 +0100 From: "Daniel P. Berrange" Message-ID: <20160429082933.GB21525@redhat.com> Reply-To: "Daniel P. Berrange" References: <1461879221-13338-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1461879221-13338-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH for 2.6] configure: Allow builds -Weverything List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developer , Peter Maydell On Thu, Apr 28, 2016 at 11:33:41PM +0200, Stefan Weil wrote: > The clang compiler supports a useful compiler option -Weverything. > > As this option triggers warnings in glib header files, too, testing > glib with -Werror will always fail. A size mismatch is also detected > without -Werror, so simply remove it. > > Signed-off-by: Stefan Weil > --- > > With this patch, it is possible to build QEMU using this configuration: > > ./configure' --cc=clang-3.7 --cxx=clang++-3.7 --extra-cflags="-Weverything -DHAVE_FSXATTR" --disable-werror > > (HAVE_FSXATTR avoids a fatal build error because of structure redefinition) > > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index ab54f3c..abd0eff 100755 > --- a/configure > +++ b/configure > @@ -2967,7 +2967,7 @@ int main(void) { > } > EOF > > -if ! compile_prog "-Werror $CFLAGS" "$LIBS" ; then > +if ! compile_prog "$CFLAGS" "$LIBS" ; then > error_exit "sizeof(size_t) doesn't match GLIB_SIZEOF_SIZE_T."\ > "You probably need to set PKG_CONFIG_LIBDIR"\ > "to point to the right pkg-config files for your"\ Reviewed-by: Daniel P. Berrange I've confirmed that this sizeof test still works as intended when the -Werror is removed. IIRC, the -Werror usage was left over from an earlier version of the patch Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|