From: Stefan Hajnoczi <stefanha@gmail.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, w.bumiller@proxmox.com,
qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/2] vvfat: Fix volume name assertion
Date: Fri, 29 Apr 2016 10:07:55 +0100 [thread overview]
Message-ID: <20160429090755.GA20753@stefanha-x1.localdomain> (raw)
In-Reply-To: <1461843366-27217-2-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Thu, Apr 28, 2016 at 01:36:05PM +0200, Kevin Wolf wrote:
> Commit d5941dd made the volume name configurable, but it didn't consider
> that the rw code compares the volume name string to assert that the
> first directory entry is the volume name. This made vvfat crash in rw
> mode.
>
> This fixes the assertion to compare with the configured volume name
> instead of a literal string.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/vvfat.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
I just noticed that Wolfgang's original patch got rid of the default
"QEMU VVFAT " volume label. It now defaults to all spaces but I'm not
sure if this causes any problems...
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-04-29 9:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-28 11:36 [Qemu-devel] [PATCH v2 0/2] vvfat: Fix regressions introduced in 2.4 Kevin Wolf
2016-04-28 11:36 ` [Qemu-devel] [PATCH v2 1/2] vvfat: Fix volume name assertion Kevin Wolf
2016-04-28 14:50 ` Peter Maydell
2016-04-28 18:29 ` Markus Armbruster
2016-04-29 9:07 ` Stefan Hajnoczi [this message]
2016-04-28 11:36 ` [Qemu-devel] [PATCH v2 2/2] vvfat: Fix default volume label Kevin Wolf
2016-04-28 18:30 ` Markus Armbruster
2016-04-29 9:08 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2016-04-28 18:02 ` [Qemu-devel] [PATCH v2 0/2] vvfat: Fix regressions introduced in 2.4 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160429090755.GA20753@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=w.bumiller@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).