From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33498) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aw9U2-0007PL-83 for qemu-devel@nongnu.org; Fri, 29 Apr 2016 10:33:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aw9Tq-00057B-Lq for qemu-devel@nongnu.org; Fri, 29 Apr 2016 10:33:24 -0400 Date: Fri, 29 Apr 2016 16:32:41 +0200 From: Kevin Wolf Message-ID: <20160429143241.GH4350@noname.redhat.com> References: <401077e94fe70110ecf66ae36474e029d8919c92.1459776815.git.berto@igalia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <401077e94fe70110ecf66ae36474e029d8919c92.1459776815.git.berto@igalia.com> Subject: Re: [Qemu-devel] [PATCH v9 03/11] block: use the block job list in qmp_query_block_jobs() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alberto Garcia Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, Max Reitz , Eric Blake , Stefan Hajnoczi Am 04.04.2016 um 15:43 hat Alberto Garcia geschrieben: > qmp_query_block_jobs() uses bdrv_next() to look for block jobs, but > this function can only find those in top-level BlockDriverStates. > > This patch uses block_job_next() instead. > > Signed-off-by: Alberto Garcia Reviewed-by: Kevin Wolf However, I'd like to give you a heads-up that this will technically conflict with my series that removes BlockDriverState.blk because that changes the bdrv_next() signature. Nothing dramatic, but I guess it would make sense to decide where in the queue of patches this series should go. My suggestion would be on top of "blockdev: (Nearly) free clean-up work". Kevin