From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56103) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1awo7N-0002pT-C4 for qemu-devel@nongnu.org; Sun, 01 May 2016 05:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1awo7B-0006Bm-OM for qemu-devel@nongnu.org; Sun, 01 May 2016 05:56:43 -0400 Date: Sun, 1 May 2016 12:55:57 +0300 From: "Michael S. Tsirkin" Message-ID: <20160501125535-mutt-send-email-mst@redhat.com> References: <1461333236-5942-1-git-send-email-famz@redhat.com> <1461333236-5942-4-git-send-email-famz@redhat.com> <20160501111428-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160501111428-mutt-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 for-2.6 3/5] virtio: Mark host notifiers as external List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Jeff Cody , Kevin Wolf , Max Reitz , Paolo Bonzini , qemu-block@nongnu.org On Sun, May 01, 2016 at 11:15:10AM +0300, Michael S. Tsirkin wrote: > On Fri, Apr 22, 2016 at 09:53:54PM +0800, Fam Zheng wrote: > > The effect of this change is the block layer drained section can work, > > for example when mirror job is being completed. > > > > Signed-off-by: Fam Zheng > > This is indentical to v2, so why don't you include the > Reviewed-by: Michael S. Tsirkin > tag I sent on v2? Oh, I asked this before. Sorry about the noise. > > --- > > hw/virtio/virtio.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/hw/virtio/virtio.c b/hw/virtio/virtio.c > > index fffa09f..30ede3d 100644 > > --- a/hw/virtio/virtio.c > > +++ b/hw/virtio/virtio.c > > @@ -1829,10 +1829,10 @@ void virtio_queue_set_host_notifier_fd_handler(VirtQueue *vq, bool assign, > > bool set_handler) > > { > > if (assign && set_handler) { > > - event_notifier_set_handler(&vq->host_notifier, false, > > + event_notifier_set_handler(&vq->host_notifier, true, > > virtio_queue_host_notifier_read); > > } else { > > - event_notifier_set_handler(&vq->host_notifier, false, NULL); > > + event_notifier_set_handler(&vq->host_notifier, true, NULL); > > } > > if (!assign) { > > /* Test and clear notifier before after disabling event, > > -- > > 2.8.0