From: "Daniel P. Berrange" <berrange@redhat.com>
To: Ashijeet Acharya <ashijeetacharya@gmail.com>
Cc: jasowang@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h
Date: Tue, 3 May 2016 15:01:14 +0100 [thread overview]
Message-ID: <20160503140114.GA11694@redhat.com> (raw)
In-Reply-To: <1462282457-24574-1-git-send-email-ashijeetacharya@gmail.com>
On Tue, May 03, 2016 at 07:04:17PM +0530, Ashijeet Acharya wrote:
> From: Ashijeet <ashijeetacharya@gmail.com>
>
> Replaced connect()/listen()/parse_host_port() in net/socket.c
> with inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h.
If you're going to re-work this, then I think it'd be better to
go straight to using socket_connect() / socket_listen() / socket_parse()
which are QAPI based. The inet_* function should eventually be going
away once everything is using the QAPI based socket_* functions, so
adding more usage of them is not too desirable.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-05-03 14:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-03 13:34 [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h Ashijeet Acharya
2016-05-03 14:01 ` Daniel P. Berrange [this message]
2016-05-03 18:13 ` Ashi
2016-05-04 8:39 ` Daniel P. Berrange
2016-05-12 9:09 ` Ashi
2016-05-12 9:18 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160503140114.GA11694@redhat.com \
--to=berrange@redhat.com \
--cc=ashijeetacharya@gmail.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).