From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33788) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axatR-0006yo-Gd for qemu-devel@nongnu.org; Tue, 03 May 2016 10:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axatF-0006zo-Ag for qemu-devel@nongnu.org; Tue, 03 May 2016 10:01:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41205) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axatF-0006wD-4u for qemu-devel@nongnu.org; Tue, 03 May 2016 10:01:29 -0400 Date: Tue, 3 May 2016 15:01:14 +0100 From: "Daniel P. Berrange" Message-ID: <20160503140114.GA11694@redhat.com> Reply-To: "Daniel P. Berrange" References: <1462282457-24574-1-git-send-email-ashijeetacharya@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1462282457-24574-1-git-send-email-ashijeetacharya@gmail.com> Subject: Re: [Qemu-devel] [PATCH] Modify net/socket.c to use functions from include/qemu/sockets.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ashijeet Acharya Cc: jasowang@redhat.com, qemu-devel@nongnu.org On Tue, May 03, 2016 at 07:04:17PM +0530, Ashijeet Acharya wrote: > From: Ashijeet > > Replaced connect()/listen()/parse_host_port() in net/socket.c > with inet_connect()/inet_listen/inet_parse() in include/qemu/sockets.h. If you're going to re-work this, then I think it'd be better to go straight to using socket_connect() / socket_listen() / socket_parse() which are QAPI based. The inet_* function should eventually be going away once everything is using the QAPI based socket_* functions, so adding more usage of them is not too desirable. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|