From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51270) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1axcBW-00009L-2Z for qemu-devel@nongnu.org; Tue, 03 May 2016 11:24:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1axcBK-0000GC-G8 for qemu-devel@nongnu.org; Tue, 03 May 2016 11:24:20 -0400 Date: Tue, 3 May 2016 17:23:36 +0200 From: Kevin Wolf Message-ID: <20160503152336.GJ3917@noname.str.redhat.com> References: <1459967330-4573-1-git-send-email-mreitz@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1459967330-4573-1-git-send-email-mreitz@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 for-2.7 00/14] qapi: Allow blockdev-add for NBD List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, Paolo Bonzini , Eric Blake , "Daniel P . Berrange" , Markus Armbruster , Luiz Capitulino Am 06.04.2016 um 20:28 hat Max Reitz geschrieben: > Turns out NBD is not so simple to do if you do it right. Anyway, this > series adds blockdev-add support for NBD clients. What the series does seems to make sense to me, though things would be a bit nicer (especially on the command line) if SocketAddress had been a flat union from the beginning. It's too late to change now, and I guess the ugliness isn't worth duplicating it. I'll leave the in-detail review to our NBD folks. Kevin