From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46040) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayTsy-000362-SL for qemu-devel@nongnu.org; Thu, 05 May 2016 20:44:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayTsn-0002xM-20 for qemu-devel@nongnu.org; Thu, 05 May 2016 20:44:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52698) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayTsm-0002th-Sq for qemu-devel@nongnu.org; Thu, 05 May 2016 20:44:40 -0400 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id C81F081114 for ; Fri, 6 May 2016 00:44:28 +0000 (UTC) Date: Fri, 6 May 2016 08:44:30 +0800 From: Fam Zheng Message-ID: <20160506004430.GA24080@ad.usersys.redhat.com> References: <20160505174515.GD14181@stefanha-x1.localdomain> <20160505190647.GF7299@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160505190647.GF7299@localhost.localdomain> Subject: Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vikhyat Umrao Cc: qemu-devel@nongnu.org On Thu, 05/05 15:06, Jeff Cody wrote: > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 2001 > > > From: Vikhyat Umrao > > > Date: Mon, 2 May 2016 21:47:31 +0530 > > > Subject: [PATCH] rbd:change error_setg() to error_setg_errno() > > > > > > Ceph RBD block driver does not use error_setg_errno() where > > > it is possible to use. This patch replaces error_setg() > > > from error_setg_errno(). > > > > > > Signed-off-by: Vikhyat Umrao > > > --- > > > block/rbd.c | 37 ++++++++++++++++++++++--------------- > > > 1 file changed, 22 insertions(+), 15 deletions(-) > > > > > > diff --git a/block/rbd.c b/block/rbd.c > > > index 5bc5b32..c286b32 100644 > > > --- a/block/rbd.c > > > +++ b/block/rbd.c > > > @@ -290,7 +290,7 @@ static int qemu_rbd_set_conf(rados_t cluster, const > > > char *conf, > > > if (only_read_conf_file) { > > > ret = rados_conf_read_file(cluster, value); > > > if (ret < 0) { > > > - error_setg(errp, "error reading conf file %s", value); > > > + error_setg_errno(errp, -ret, "error reading conf file > > > %s", value); > > > > Please use scripts/checkpatch.pl to scan patches for coding style > > violations. This line exceeds the maximum line length. > > > Also, if you can use something like git send-email, it formats the patch > emails much nicer -- which makes it easier to review & apply. Also please use ./scripts/get_maintainer.pl to get a more complete recipient list (for example it will report qemu-block@nongnu.org and other block layer maintainers). Fam