From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40977) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayie4-00040S-RM for qemu-devel@nongnu.org; Fri, 06 May 2016 12:30:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ayids-0006x0-Tb for qemu-devel@nongnu.org; Fri, 06 May 2016 12:30:23 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:35705) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ayidr-0006nv-Gp for qemu-devel@nongnu.org; Fri, 06 May 2016 12:30:16 -0400 Received: by mail-wm0-x244.google.com with SMTP id e201so9573153wme.2 for ; Fri, 06 May 2016 09:30:01 -0700 (PDT) Date: Fri, 6 May 2016 17:29:55 +0100 From: Stefan Hajnoczi Message-ID: <20160506162955.GD23075@stefanha-x1.localdomain> References: <20160505174515.GD14181@stefanha-x1.localdomain> <20160505190647.GF7299@localhost.localdomain> <20160506004430.GA24080@ad.usersys.redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="qGV0fN9tzfkG3CxV" Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] rbd:change error_setg() to error_setg_errno() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vikhyat Umrao Cc: Fam Zheng , qemu-devel@nongnu.org --qGV0fN9tzfkG3CxV Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, May 06, 2016 at 10:44:41AM +0530, Vikhyat Umrao wrote: > On Fri, May 6, 2016 at 6:14 AM, Fam Zheng wrote: >=20 > > On Thu, 05/05 15:06, Jeff Cody wrote: > > > On Thu, May 05, 2016 at 06:45:15PM +0100, Stefan Hajnoczi wrote: > > > > On Mon, May 02, 2016 at 09:55:17PM +0530, Vikhyat Umrao wrote: > > > > > From 1c63c246f47a1a65d8740d7ce3725fe3820c0a37 Mon Sep 17 00:00:00 > > 2001 > > > > > From: Vikhyat Umrao > > > > > Date: Mon, 2 May 2016 21:47:31 +0530 > > > > > Subject: [PATCH] rbd:change error_setg() to error_setg_errno() > > > > > > > > > > Ceph RBD block driver does not use error_setg_errno() where > > > > > it is possible to use. This patch replaces error_setg() > > > > > from error_setg_errno(). > > > > > > > > > > Signed-off-by: Vikhyat Umrao > > > > > --- > > > > > block/rbd.c | 37 ++++++++++++++++++++++--------------- > > > > > 1 file changed, 22 insertions(+), 15 deletions(-) > > > > > > > > > > diff --git a/block/rbd.c b/block/rbd.c > > > > > index 5bc5b32..c286b32 100644 > > > > > --- a/block/rbd.c > > > > > +++ b/block/rbd.c > > > > > @@ -290,7 +290,7 @@ static int qemu_rbd_set_conf(rados_t cluster, > > const > > > > > char *conf, > > > > > if (only_read_conf_file) { > > > > > ret =3D rados_conf_read_file(cluster, value); > > > > > if (ret < 0) { > > > > > - error_setg(errp, "error reading conf file %s= ", > > value); > > > > > + error_setg_errno(errp, -ret, "error reading > > conf file > > > > > %s", value); > > > > > > > > Please use scripts/checkpatch.pl to scan patches for coding style > > > > violations. This line exceeds the maximum line length. > > > > > > > > > Also, if you can use something like git send-email, it formats the pa= tch > > > emails much nicer -- which makes it easier to review & apply. > > > > Also please use ./scripts/get_maintainer.pl to get a more complete > > recipient > > list (for example it will report qemu-block@nongnu.org and other block > > layer maintainers). > > > > Fam > > >=20 > Thank you everyone for your inputs. Sure I will fix the current patch and > will check it with given scripts and then will send patch v2. This page has the guidelines for submitting patches: http://qemu-project.org/Contribute/SubmitAPatch Stefan --qGV0fN9tzfkG3CxV Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXLMaDAAoJEJykq7OBq3PIy0cIAL10VIIURFxth24uCb+vKHY4 NREoNAAMMF4+34Ov3D+LTscSwxZKYX9mde5+Bao750Rs5onZno9IvOezgFg+bz4w Xqbjccdf2xpPT/R1EjzQJW5r3wb9lNKGMRaDLeE3OYTmeH2/ycQyEdeZbrItyeSR ur+c4YrOxCYmJ2VW3OmNGiNQe9DgBfyPUmE5vUxw5652jSlqj4VFEPTShTmTtgEd POH0l7a12Kuw8VkE9rBLbq/oEBSp01/X621UF0hm1PooT/JkI12dV0CDLVJomwE6 ajVLMX5NIWuHksJlznQsyYLT9MQ9/Ukq/CnuLbNiHhEYyxosTnzqEZgnsWk++K4= =EpP+ -----END PGP SIGNATURE----- --qGV0fN9tzfkG3CxV--