From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43700) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azfYI-0003jG-53 for qemu-devel@nongnu.org; Mon, 09 May 2016 03:24:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azfYE-0005hS-S9 for qemu-devel@nongnu.org; Mon, 09 May 2016 03:24:26 -0400 Received: from e06smtp08.uk.ibm.com ([195.75.94.104]:50492) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azfYE-0005gR-IP for qemu-devel@nongnu.org; Mon, 09 May 2016 03:24:22 -0400 Received: from localhost by e06smtp08.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 May 2016 08:24:20 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp03.portsmouth.uk.ibm.com (Postfix) with ESMTP id 79A221B0805F for ; Mon, 9 May 2016 08:25:10 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u497OH2q5439950 for ; Mon, 9 May 2016 07:24:17 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u497OHRY021364 for ; Mon, 9 May 2016 03:24:17 -0400 Date: Mon, 9 May 2016 09:24:15 +0200 From: David Hildenbrand Message-ID: <20160509092415.6893cde8@thinkpad-w530> In-Reply-To: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> References: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/9] Add runnability info to query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Jiri Denemark , Andreas =?UTF-8?B?RsOkcmJlcg==?= , Igor Mammedov , libvir-list@redhat.com, Michael Mueller , Christian Borntraeger , Cornelia Huck > This series extends query-cpu-definitions to include two extra > fields: "runnable", and "unavailable-features". > > This will return information based on the current machine and > accelerator only. In the future we may extend these mechanisms to > allow querying other machines and other accelerators without > restarting QEMU, but it will require some reorganization of > QEMU's main code. Hi Eduardo, just as discussed during/after the last kvm forum offline, we are currently working on a new set of qmp functions to keep all the cpu model details in QEMU and not have to replicate them in libvirt and to have a nice way to query the host cpu model. We already have a prototype running, just need to clarify some s390x details (feature set of the CPU generations) before we can send out an RFC. I could, however, send out just the interface changes + details on the concept upfront, if anybody is interested. In the current implementation: - s390x cpu models will be independent of the QEMU machine, so for s390x the runnability information will only depend on the accelerator (host cpu model). However, for compatibility machines, cpu models will be disabled, and we won't therefore have any runnability information. - we will not touch query-cpu-definitions - the new interfaces will also make use of the current accelerator and the current machine, so the context of these functions are the same. Adding functionality to query for other machines is not necessary for s390x. Other accelerators don't really make sense to me, let's keep it simple here. So this change is fine from my point of view. It doesn't contradict to out concept. David