From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azgy2-00068c-K1 for qemu-devel@nongnu.org; Mon, 09 May 2016 04:55:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azgxx-0008R1-DJ for qemu-devel@nongnu.org; Mon, 09 May 2016 04:55:05 -0400 Received: from e06smtp12.uk.ibm.com ([195.75.94.108]:52544) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azgxw-0008Qf-TC for qemu-devel@nongnu.org; Mon, 09 May 2016 04:55:01 -0400 Received: from localhost by e06smtp12.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 9 May 2016 09:54:58 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 1C95B2190046 for ; Mon, 9 May 2016 09:54:31 +0100 (BST) Received: from d06av09.portsmouth.uk.ibm.com (d06av09.portsmouth.uk.ibm.com [9.149.37.250]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u498stdA1966558 for ; Mon, 9 May 2016 08:54:55 GMT Received: from d06av09.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av09.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u498ssP9001892 for ; Mon, 9 May 2016 02:54:55 -0600 Date: Mon, 9 May 2016 10:54:53 +0200 From: David Hildenbrand Message-ID: <20160509105453.57b54a89@thinkpad-w530> In-Reply-To: <1462558292-2126-8-git-send-email-ehabkost@redhat.com> References: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> <1462558292-2126-8-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Jiri Denemark , Andreas =?UTF-8?B?RsOkcmJlcg==?= , Igor Mammedov , libvir-list@redhat.com, Michael Mueller , Christian Borntraeger , Cornelia Huck > Extend query-cpu-definitions schema to allow it to return two new > optional fields: "runnable" and "unavailable-features". > "runnable" will tell if the CPU model can be run in the current > host. "unavailable-features" will contain a list of CPU > properties that are preventing the CPU model from running in the > current host. > > Cc: David Hildenbrand > Cc: Michael Mueller > Cc: Christian Borntraeger > Cc: Cornelia Huck > Cc: Jiri Denemark > Cc: libvir-list@redhat.com > Signed-off-by: Eduardo Habkost > --- > qapi-schema.json | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 54634c4..450e6e7 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -2948,11 +2948,19 @@ > # Virtual CPU definition. > # > # @name: the name of the CPU definition > +# @runnable: true if the CPU model is runnable using the current > +# machine and accelerator. Optional. Since 2.6. > +# @unavailable-features: List of properties that prevent the CPU > +# model from running in the current host, > +# if @runnable is false. Optional. > +# Since 2.6. Just FYI, on other architectures (e.g. s390x), other conditions (e.g. cpu generation) also define if a CPU model is runnable, so the pure availability of features does not mean that a cpu model is runnable. We could have runnable=false and unavailable-features being an empty list. > # > # Since: 1.2.0 > ## > { 'struct': 'CpuDefinitionInfo', > - 'data': { 'name': 'str' } } > + 'data': { 'name': 'str', > + '*runnable': 'bool', > + '*unavailable-features': [ 'str' ] } } > > ## > # @query-cpu-definitions: David