From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47042)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1azkXd-0006p9-C5
	for qemu-devel@nongnu.org; Mon, 09 May 2016 08:44:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1azkXb-0003od-C7
	for qemu-devel@nongnu.org; Mon, 09 May 2016 08:44:04 -0400
Date: Mon, 9 May 2016 13:43:55 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20160509124355.GC3372@stefanha-x1.localdomain>
References: <1461346962-4676-1-git-send-email-kwolf@redhat.com>
	<1461346962-4676-6-git-send-email-kwolf@redhat.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="Y5rl02BVI9TCfPar"
Content-Disposition: inline
In-Reply-To: <1461346962-4676-6-git-send-email-kwolf@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/13] block: Move
 throttling fields from BDS to BB
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com


--Y5rl02BVI9TCfPar
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Apr 22, 2016 at 07:42:34PM +0200, Kevin Wolf wrote:
> @@ -1527,7 +1525,7 @@ static int bdrv_open_inherit(BlockDriverState **pbs=
, const char *filename,
>              return -ENODEV;
>          }
> =20
> -        if (bs->throttle_state) {
> +        if (blk_get_public(bs->blk)->throttle_state) {

The reference argument can be any nodename.  How can you be sure bs->blk
!=3D NULL?

--Y5rl02BVI9TCfPar
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJXMIYLAAoJEJykq7OBq3PIc70H/AoKfy0zicMX/b/elygMAEbK
W5o9cCURIwXyqVXzLp4d0nrGgSDY4rdw9Gu4YmoCYiuIxbuoPtQ/7XHb+5gdaosU
5bnYnS59o1K7DOrFHHWcB9vIFlxRHkAWRubARntFPWrfo3gPBMkLmldecmrIJpjE
bgmeFJAftCQ18or0sboCa2bknAEuBDrRJREBd9wbL+/D2YxAdI3M8GC49pW8iCpz
yG7x/ZJCKT5spLyEseWpUw87SoNsdiKWpJaacup1ybSWnjQIxlyx9MX/e021acwQ
p2BUCCfA4bz1f4wdhr+zU65m06qEpT9OeHg5zwAB9Dv1U7306szsWu1itULfE38=
=NnBc
-----END PGP SIGNATURE-----

--Y5rl02BVI9TCfPar--