From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azmHW-0003Hl-EO for qemu-devel@nongnu.org; Mon, 09 May 2016 10:35:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azmHT-0001tw-5o for qemu-devel@nongnu.org; Mon, 09 May 2016 10:35:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:49500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azmHS-0001tb-V5 for qemu-devel@nongnu.org; Mon, 09 May 2016 10:35:31 -0400 Date: Mon, 9 May 2016 16:35:24 +0200 From: Radim =?utf-8?B?S3LEjW3DocWZ?= Message-ID: <20160509143520.GA6073@potion> References: <1462568028-31037-1-git-send-email-rkrcmar@redhat.com> <20160509053629.GA25124@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160509053629.GA25124@pxdev.xzpeter.org> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC 0/4] APIC, IOMMU, KVM: add x2APIC interface List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Paolo Bonzini , "Lan, Tianyu" , Igor Mammedov , Jan Kiszka , Eduardo Habkost , Richard Henderson 2016-05-09 13:36+0800, Peter Xu: > On Fri, May 06, 2016 at 10:53:44PM +0200, Radim Kr=C4=8Dm=C3=A1=C5=99 w= rote: >> This series bases on Peter's IR v6 and depends on patches that were ju= st >> posted to kvm-list, "[RFC 0/9] KVM: x86: break the xAPIC barrier". >>=20 >> The kernel interface could use your comments, but internal QEMU one is >> in dire need of them. Please see [1/4]. >>=20 >> I have tested the series and seems to work as well as it can. >> Peter's IR v6 didn't boot on my setup, so I reverted to the latest >> version I know was working, v4, and rebased paches for testing. >=20 > Radim, >=20 > Would you please provide your test setup? So that I can try to > reproduce it on my machine and debug it.=20 I could reproduce with a kernel based off kvm/queue (basically 4.6-rc3), that was make olconfig with fedora rawhide config for 4.6-rc3 and qemu/master (53db932604d) after pulling your vtd-intr-v6 and doing the minimum to make ./configure happy. The bug was caused by pci-bridge, which I didn't remove from a copy-pasted qemu line ... Linux boot hangs if QEMU is ran with -device i82801b11-bridge,id=3Dpci.1,bus=3Dpcie.0,addr=3D0x1e \ -device pci-bridge,chassis_nr=3D2,id=3Dpci.2,bus=3Dpci.1,addr=3D0x0 \ -drive file=3D/home/rhel7.qcow2,format=3Dqcow2,if=3Dnone,id=3Ddrive-virt= io-disk0 \ -device virtio-blk-pci,scsi=3Doff,bus=3Dpci.2,addr=3D0x3,drive=3Ddrive-v= irtio-disk0,id=3Dvirtio-disk0,bootindex=3D1 \ but the following works -drive file=3D/home/rhel7.qcow2,format=3Dqcow2,if=3Dnone,id=3Ddrive-virt= io-disk0 \ -device virtio-blk-pci,scsi=3Doff,bus=3Dpcie.0,drive=3Ddrive-virtio-disk= 0,id=3Dvirtio-disk0,bootindex=3D1 \ I can give you ssh access to the machine too. >> The setup from Igor's latest x2APIC QEMU patches creates two VCPUs, >> first has id 0 and second has 280. Edge IO-APIC and MSI interrupts >> were being delivered to both of them, but level didn't work -- only >> one interrupt was ever delivered, I blame EOI. >=20 > Not sure whether this is related to the v5 fix on kernel EOI hack > (the two patches that you have reviewed)? That two patches should > solve the level-triggered interrupt issue that I have encountered, > like e1000 cards. I didn't try the R/O preserving patch, but the other one on top of v4 changed nothing. (There might be some kernel bugs too, because I expected that EOI would start working with it ...)