From: "Radim Krčmář" <rkrcmar@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: ehabkost@redhat.com, mst@redhat.com, jasowang@redhat.com,
qemu-devel@nongnu.org, alex.williamson@redhat.com,
jan.kiszka@web.de, wexu@redhat.com, imammedo@redhat.com,
marcel@redhat.com, pbonzini@redhat.com, davidkiarie4@gmail.com,
rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH v6 00/26] IOMMU: Enable interrupt remapping for Intel IOMMU
Date: Mon, 9 May 2016 22:37:24 +0200 [thread overview]
Message-ID: <20160509203724.GA806@potion> (raw)
In-Reply-To: <20160509171525.GA9224@potion>
2016-05-09 19:15+0200, Radim Krčmář:
> From: =?UTF-8?q?Radim=20Kr=C4=8Dm=C3=A1=C5=99?= <rkrcmar@redhat.com>
> Date: Mon, 9 May 2016 19:04:56 +0200
> Subject: [PATCH] intel_iommu: support all masks in interrupt entry cache
> invalidation
>
> Linux guests do not gracefully handle cases when the invalidation mask
> they wanted is not supported, probably because real hardware always
> allowed all.
>
> We can just say that all 16 masks are supported, because both
> ioapic_iec_notifier and kvm_update_msi_routes_all invalidate all caches.
>
> Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
> ---
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> @@ -2359,7 +2359,7 @@ static void vtd_init(IntelIOMMUState *s)
> s->ecap = VTD_ECAP_QI | VTD_ECAP_IRO;
>
> if (ms->iommu_intr) {
> - s->ecap |= VTD_ECAP_IR | VTD_ECAP_EIM;
> + s->ecap |= VTD_ECAP_IR | VTD_ECAP_EIM | VTD_ECAP_MHVM;
Eh, I really cannot spell ... this one should read VTD_ECAP_MHMV.
(... or compile after a last-second renaming.)
> diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
> @@ -186,6 +186,7 @@
> +#define VTD_ECAP_MHMV (15ULL << 20)
next prev parent reply other threads:[~2016-05-09 20:37 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-05 3:25 [Qemu-devel] [PATCH v6 00/26] IOMMU: Enable interrupt remapping for Intel IOMMU Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 01/26] acpi: enable INTR for DMAR report structure Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 02/26] intel_iommu: allow queued invalidation for IR Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 03/26] intel_iommu: set IR bit for ECAP register Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 04/26] acpi: add DMAR scope definition for root IOAPIC Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 05/26] intel_iommu: define interrupt remap table addr register Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 06/26] intel_iommu: handle interrupt remap enable Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 07/26] intel_iommu: define several structs for IOMMU IR Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 08/26] intel_iommu: provide helper function vtd_get_iommu Peter Xu
2016-05-05 9:29 ` David Kiarie
2016-05-09 6:15 ` Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 09/26] intel_iommu: add IR translation faults defines Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 10/26] intel_iommu: Add support for PCI MSI remap Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 11/26] q35: ioapic: add support for emulated IOAPIC IR Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 12/26] ioapic: introduce ioapic_entry_parse() helper Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 13/26] intel_iommu: add support for split irqchip Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 14/26] q35: add "intremap" parameter to enable IR Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 15/26] intel_iommu: introduce IEC notifiers Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 16/26] ioapic: register VT-d IEC invalidate notifier Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 17/26] ioapic: keep RO bits for IOAPIC entry Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 18/26] ioapic: clear remote irr bit for edge-triggered interrupts Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 19/26] intel_iommu: Add support for Extended Interrupt Mode Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 20/26] intel_iommu: add SID validation for IR Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 21/26] x86-iommu: introduce parent class Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 22/26] x86-iommu: replace existing VT-d hooks into X86 ones Peter Xu
2016-05-05 9:35 ` Jan Kiszka
2016-05-09 5:23 ` Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 23/26] kvm-irqchip: simplify kvm_irqchip_add_msi_route Peter Xu
2016-05-05 3:25 ` [Qemu-devel] [PATCH v6 24/26] kvm-irqchip: i386: add hook for add/remove virq Peter Xu
2016-05-09 8:02 ` Peter Xu
2016-05-10 8:11 ` Peter Xu
2016-05-05 3:26 ` [Qemu-devel] [PATCH v6 25/26] kvm-irqchip: x86: add msi route notify fn Peter Xu
2016-05-05 3:26 ` [Qemu-devel] [PATCH v6 26/26] kvm-irqchip: do explicit commit when update irq Peter Xu
2016-05-05 4:36 ` [Qemu-devel] [PATCH v6 00/26] IOMMU: Enable interrupt remapping for Intel IOMMU Peter Xu
2016-05-09 17:15 ` Radim Krčmář
2016-05-09 20:37 ` Radim Krčmář [this message]
2016-05-10 6:16 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160509203724.GA806@potion \
--to=rkrcmar@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=davidkiarie4@gmail.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).