From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b03GB-0002dE-QE for qemu-devel@nongnu.org; Tue, 10 May 2016 04:43:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b03G8-00055L-Gn for qemu-devel@nongnu.org; Tue, 10 May 2016 04:43:19 -0400 Date: Tue, 10 May 2016 09:43:04 +0100 From: "Richard W.M. Jones" Message-ID: <20160510084303.GB28935@redhat.com> References: <1462848659-28659-1-git-send-email-famz@redhat.com> <20160510081425.GV1683@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160510081425.GV1683@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 00/27] block: Lock images when opening List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng Cc: Kevin Wolf , qemu-block@nongnu.org, John Snow , Jeff Cody , Markus Armbruster , qemu-devel@nongnu.org, stefanha@redhat.com, den@openvz.org, pbonzini@redhat.com, Max Reitz On Tue, May 10, 2016 at 09:14:26AM +0100, Richard W.M. Jones wrote: > However I didn't test the write-shareable case (the libvirt > flag which should map to a shared lock -- is that right Dan?). To Dan (mainly): I think setting the flag in libvirt only sets cache=unsafe on the qemu drive (it may have other effects for virtlockd). Should there be an extra qemu drive flag to communicate that the drive is write-shareable? Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Read my programming and virtualization blog: http://rwmj.wordpress.com libguestfs lets you edit virtual machines. Supports shell scripting, bindings from many languages. http://libguestfs.org