From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37824) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09J2-0000jc-3w for qemu-devel@nongnu.org; Tue, 10 May 2016 11:10:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b09Iv-0006E5-BE for qemu-devel@nongnu.org; Tue, 10 May 2016 11:10:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09Iv-0006Di-4q for qemu-devel@nongnu.org; Tue, 10 May 2016 11:10:33 -0400 Date: Tue, 10 May 2016 17:10:30 +0200 From: Igor Mammedov Message-ID: <20160510171030.5ceaea6a@nial.brq.redhat.com> In-Reply-To: <1462558292-2126-3-git-send-email-ehabkost@redhat.com> References: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> <1462558292-2126-3-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/9] target-i386: Move TCG initialization to realize time List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, libvir-list@redhat.com, Jiri Denemark , Andreas =?UTF-8?B?RsOkcmJlcg==?= On Fri, 6 May 2016 15:11:25 -0300 Eduardo Habkost wrote: > QOM instance_init functions are not supposed to have any side-effects, > as new objects may be created at any moment for querying property > information (see qmp_device_list_properties()). > > Move TCG initialization to realize time so it won't be called when just > doing object_new() on a X86CPU subclass. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Changes v1 -> v2: > * Now the inited/tcg_initialized variable doesn't exist anymore > * Move tcg_x86_init() call after basic parameter validation inside > realizefn > --- > target-i386/cpu.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index a689fec..bde649a 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -2901,6 +2901,10 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > } > > > + if (tcg_enabled()) { > + tcg_x86_init(); > + } > + > #ifndef CONFIG_USER_ONLY > qemu_register_reset(x86_cpu_machine_reset_cb, cpu); > > @@ -3135,11 +3139,6 @@ static void x86_cpu_initfn(Object *obj) > } > > x86_cpu_load_def(cpu, xcc->cpu_def, &error_abort); > - > - /* init various static tables used in TCG mode */ > - if (tcg_enabled()) { > - tcg_x86_init(); > - } > } > > static int64_t x86_cpu_get_arch_id(CPUState *cs)