From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09Nf-00052g-Os for qemu-devel@nongnu.org; Tue, 10 May 2016 11:15:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b09NZ-0007TD-Pk for qemu-devel@nongnu.org; Tue, 10 May 2016 11:15:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53331) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b09NZ-0007T4-HV for qemu-devel@nongnu.org; Tue, 10 May 2016 11:15:21 -0400 Date: Tue, 10 May 2016 17:15:18 +0200 From: Igor Mammedov Message-ID: <20160510171518.6a00b65d@nial.brq.redhat.com> In-Reply-To: <1462558292-2126-4-git-send-email-ehabkost@redhat.com> References: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> <1462558292-2126-4-git-send-email-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/9] target-i386: Call cpu_exec_init() on realize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Jiri Denemark , Andreas =?UTF-8?B?RsOkcmJlcg==?= , libvir-list@redhat.com On Fri, 6 May 2016 15:11:26 -0300 Eduardo Habkost wrote: > QOM instance_init functions are not supposed to have any side-effects, > as new objects may be created at any moment for querying property > information (see qmp_device_list_properties()). > > Calling cpu_exec_init() also affects QEMU's ability to handle errors > during CPU creation, as some actions done by cpu_exec_init() can't be > reverted. > > Move cpu_exec_init() call to realize so a simple object_new() won't > trigger it, and so that it is called after some basic validation of CPU > parameters. > > Signed-off-by: Eduardo Habkost Reviewed-by: Igor Mammedov > --- > Changes v1 -> v2: > * Call cpu_exec_init() after basic parameter validation > --- > target-i386/cpu.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/target-i386/cpu.c b/target-i386/cpu.c > index bde649a..26a5a6b 100644 > --- a/target-i386/cpu.c > +++ b/target-i386/cpu.c > @@ -2901,6 +2901,8 @@ static void x86_cpu_realizefn(DeviceState *dev, Error **errp) > } > > > + cpu_exec_init(cs, &error_abort); > + > if (tcg_enabled()) { > tcg_x86_init(); > } > @@ -3093,7 +3095,6 @@ static void x86_cpu_initfn(Object *obj) > FeatureWord w; > > cs->env_ptr = env; > - cpu_exec_init(cs, &error_abort); > > object_property_add(obj, "family", "int", > x86_cpuid_version_get_family,