From: Fam Zheng <famz@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] block: Inactivate all children
Date: Wed, 11 May 2016 09:51:24 +0800 [thread overview]
Message-ID: <20160511015124.GD13488@ad.usersys.redhat.com> (raw)
In-Reply-To: <20160510083331.GB4921@noname.str.redhat.com>
On Tue, 05/10 10:33, Kevin Wolf wrote:
>
> Fair enough. My series didn't have a separate callback, but with yours
> that should be working.
>
> So is the semantics of .bdrv_inactivate() basically "bdrv_flush, and I
> really mean it"?
Yes.
>
> > > Maybe we need something like an "active reference counter", and we
> > > decrement that for all children and only call their .bdrv_inactivate()
> > > when it arrives at 0.
> >
> > That should work, but the effect of the counters are local to one invocation of
> > bdrv_inactivate_all(), and is not really necessary if we do as above.
>
> Agreed.
Working on another version now.
Fam
prev parent reply other threads:[~2016-05-11 1:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-19 1:42 [Qemu-devel] [PATCH 0/2] block: More complete inactivate/invalidate of on graph Fam Zheng
2016-04-19 1:42 ` [Qemu-devel] [PATCH 1/2] block: Invalidate all children Fam Zheng
2016-04-19 8:44 ` Changlong Xie
2016-04-19 12:23 ` Fam Zheng
2016-05-04 10:10 ` Kevin Wolf
2016-05-05 0:32 ` Fam Zheng
2016-04-19 1:42 ` [Qemu-devel] [PATCH 2/2] block: Inactivate " Fam Zheng
2016-05-04 10:12 ` Kevin Wolf
2016-05-05 0:32 ` Fam Zheng
2016-05-06 7:49 ` Kevin Wolf
2016-05-10 3:23 ` Fam Zheng
2016-05-10 8:33 ` Kevin Wolf
2016-05-11 1:51 ` Fam Zheng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160511015124.GD13488@ad.usersys.redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).