From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46821) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0TWT-0001aD-Ho for qemu-devel@nongnu.org; Wed, 11 May 2016 08:45:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0TWR-0007h1-D4 for qemu-devel@nongnu.org; Wed, 11 May 2016 08:45:52 -0400 Date: Wed, 11 May 2016 14:45:40 +0200 From: Kevin Wolf Message-ID: <20160511124540.GG4524@noname.str.redhat.com> References: <1461346962-4676-1-git-send-email-kwolf@redhat.com> <1461346962-4676-6-git-send-email-kwolf@redhat.com> <20160509124355.GC3372@stefanha-x1.localdomain> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline In-Reply-To: <20160509124355.GC3372@stefanha-x1.localdomain> Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v2 05/13] block: Move throttling fields from BDS to BB List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com, pbonzini@redhat.com --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Am 09.05.2016 um 14:43 hat Stefan Hajnoczi geschrieben: > On Fri, Apr 22, 2016 at 07:42:34PM +0200, Kevin Wolf wrote: > > @@ -1527,7 +1525,7 @@ static int bdrv_open_inherit(BlockDriverState **p= bs, const char *filename, > > return -ENODEV; > > } > > =20 > > - if (bs->throttle_state) { > > + if (blk_get_public(bs->blk)->throttle_state) { >=20 > The reference argument can be any nodename. How can you be sure bs->blk > !=3D NULL? Good catch, this should check bs->blk !=3D NULL first. This check goes away later in series, but I'll fix it anyway. Kevin --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (GNU/Linux) iQIcBAEBAgAGBQJXMyl0AAoJEH8JsnLIjy/Wg+gP/0tAx7r8kvvqcivdJo6ZBW6I zCoL8IKCSWulASWiTA86beCdv/6jfm/S77vD5kHSbWlM7iOAYtqrAA6xu//9VlBi P+J7bB0cmDQiLnVya/Wrg76WkEEpAKce5LdfnvTVOj+07184N04c1qvqvPczY0j4 8E32yFWawpEw3ZSUF8Rma9dDq38U6+xO3R/PxgLDKYX/lh6SuaeyzShu77f9Pbi0 p+rdT719tPObXtItgvcKxdLiKJlQkOAD9WSWezarAF9O3+iTxSSsI9u7CGUddOFi YE8eIyhZkUVCZjDTsgn+C+TvuPPE4pzTcGPrqx+vqd3ei4E/Yt0ZxpZxphnB9LWr 8Y7pGQ3XvmJWclbqelLfvE357FPn5oH933bh9Kpa3yWFvqdBBfd0IqXCrWTobF8o FXQYmPRLI8MfHle5n4dgdnm/GVgRZREgAscUlHESKbleymH8wIeMfUCpgMne+zXZ e8GUhKudZlnr00Ih9sF7olnr43qFWKazdJRYPOmETzrGMh7zBDZB5Jftm1ZVPQWB qny4PY5y+pjR/Pg2EPkKAcSPpukwFpLTUktefPVye6vEKJ2npRh2tJVHYx6a0zGR VcwLPT/PpMdDodlkEIY+YsRS4ITr9RB51MgNGqBnBnliye6wRUuyEu2PDvs7H+Ea O9oM8ZYeQQhWMAWy9XOg =Q1kw -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY--