From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50784) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0lLR-0005Th-Dw for qemu-devel@nongnu.org; Thu, 12 May 2016 03:47:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0lLP-0002kf-Ov for qemu-devel@nongnu.org; Thu, 12 May 2016 03:47:41 -0400 Date: Thu, 12 May 2016 08:47:30 +0100 From: "Daniel P. Berrange" Message-ID: <20160512074730.GA20947@redhat.com> Reply-To: "Daniel P. Berrange" References: <1463006384-7734-1-git-send-email-eblake@redhat.com> <1463006384-7734-10-git-send-email-eblake@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1463006384-7734-10-git-send-email-eblake@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Kevin Wolf , pbonzini@redhat.com, alex@alex.org.uk, qemu-block@nongnu.org, Max Reitz On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote: > The NBD protocol allows servers to advertise a human-readable > description alongside an export name during NBD_OPT_LIST. Add > an option to pass through the user's string to the NBD client. > > Doing this also makes it easier to test commit 200650d4, which > is the client counterpart of receiving the description. > > Signed-off-by: Eric Blake > --- > include/block/nbd.h | 1 + > nbd/nbd-internal.h | 5 +++-- > nbd/server.c | 34 ++++++++++++++++++++++++++-------- > qemu-nbd.c | 12 +++++++++++- > qemu-nbd.texi | 5 ++++- > 5 files changed, 45 insertions(+), 12 deletions(-) > diff --git a/qemu-nbd.texi b/qemu-nbd.texi > index 9f23343..923de74 100644 > --- a/qemu-nbd.texi > +++ b/qemu-nbd.texi > @@ -79,9 +79,12 @@ Disconnect the device @var{dev} > Allow up to @var{num} clients to share the device (default @samp{1}) > @item -t, --persistent > Don't exit on the last connection > -@item -x NAME, --export-name=NAME > +@item -x, --export-name=@var{name} Why this change - that reads as saying that '-x' doesn't take any value which is wrong IMHO > Set the NBD volume export name. This switches the server to use > the new style NBD protocol negotiation > +@item -D, --description=@var{description} Likewise this suggests -D doesn't take a value > +Set the NBD volume export description, as a human-readable > +string. Requires the use of @option{-x} > @item --tls-creds=ID > Enable mandatory TLS encryption for the server by setting the ID > of the TLS credentials object previously created with the --object Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|