From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38916) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0kOU-00033A-LM for qemu-devel@nongnu.org; Thu, 12 May 2016 02:46:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0kOR-0005Oo-4d for qemu-devel@nongnu.org; Thu, 12 May 2016 02:46:46 -0400 Received: from e06smtp09.uk.ibm.com ([195.75.94.105]:49268) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0kOQ-0005Ng-PM for qemu-devel@nongnu.org; Thu, 12 May 2016 02:46:43 -0400 Received: from localhost by e06smtp09.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 12 May 2016 07:46:38 +0100 Received: from b06cxnps4076.portsmouth.uk.ibm.com (d06relay13.portsmouth.uk.ibm.com [9.149.109.198]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id D953F17D805D for ; Thu, 12 May 2016 07:47:33 +0100 (BST) Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com [9.149.37.248]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u4C6kaot8258018 for ; Thu, 12 May 2016 06:46:36 GMT Received: from d06av07.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av07.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u4C6kZVL001708 for ; Thu, 12 May 2016 02:46:36 -0400 Date: Thu, 12 May 2016 08:46:34 +0200 From: David Hildenbrand Message-ID: <20160512084634.4b52c447@thinkpad-w530> In-Reply-To: <20160511193550.GD24153@thinpad.lan.raisama.net> References: <1462558292-2126-1-git-send-email-ehabkost@redhat.com> <1462558292-2126-8-git-send-email-ehabkost@redhat.com> <5730AAAF.7040205@redhat.com> <20160509192515.GU4457@thinpad.lan.raisama.net> <877ff2fhjf.fsf@dusky.pond.sub.org> <20160510115705.GX4457@thinpad.lan.raisama.net> <87bn4djcgq.fsf@dusky.pond.sub.org> <20160511193550.GD24153@thinpad.lan.raisama.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [libvirt] [PATCH 7/9] qmp: Add runnability information to query-cpu-definitions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Markus Armbruster , libvir-list@redhat.com, qemu-devel@nongnu.org, Christian Borntraeger , Cornelia Huck , Igor Mammedov , Jiri Denemark , Andreas =?UTF-8?B?RsOkcmJlcg==?= > Updated to: > > ## > # @CpuDefinitionInfo: > # > # Virtual CPU definition. > # > # @name: the name of the CPU definition > # @runnable: #optional. whether the CPU model us usable with the > # current machine and accelerator. Omitted if we don't > # know the answer. (since 2.7) > # @unavailable-features: List of attributes that prevent the CPU "List of properties" ? > # model from running in the current host. > # (since 2.7) > # > # @unavailable-features is a list of QOM property names that > # represent CPU model attributes that prevent the CPU from running. > # If the QOM property is read-only, that means the CPU model can > # never run in the current host. If the property is read-write, it > # means that it MAY be possible to run the CPU model in the current > # host if that property is changed. Management software can use it > # as hints to suggest or choose an alternative for the user, or > # just to generate meaningful error messages explaining why the CPU > # model can't be used. > # > # Since: 1.2.0 > ## > what about changing unavailable-features to problematic-properties responsible-properties ... anything else making clear that we are dealing with properties, not only features? Apart from that, sounds good to me. David