From: "Michael S. Tsirkin" <mst@redhat.com>
To: minyard@acm.org
Cc: Igor Mammedov <imammedo@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, Corey Minyard <cminyard@mvista.com>
Subject: Re: [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device
Date: Thu, 12 May 2016 10:36:01 +0300 [thread overview]
Message-ID: <20160512103501-mutt-send-email-mst@redhat.com> (raw)
In-Reply-To: <1462995966-1184-8-git-send-email-minyard@acm.org>
On Wed, May 11, 2016 at 02:46:06PM -0500, minyard@acm.org wrote:
> From: Corey Minyard <cminyard@mvista.com>
>
> Signed-off-by: Corey Minyard <cminyard@mvista.com>
> ---
> hw/ipmi/smbus_ipmi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/ipmi/smbus_ipmi.c b/hw/ipmi/smbus_ipmi.c
> index 4e7203b..3a34aaf 100644
> --- a/hw/ipmi/smbus_ipmi.c
> +++ b/hw/ipmi/smbus_ipmi.c
> @@ -167,6 +167,7 @@ static void smbus_ipmi_realize(DeviceState *dev, Error **errp)
> sid->fwinfo.base_address = sid->parent.i2c.address;
> sid->fwinfo.memspace = IPMI_MEMSPACE_SMBUS;
> sid->fwinfo.register_spacing = 1;
> + sid->fwinfo.acpi_parent = "\\_SB.PCI0.SMB0";
I don't think it's a good idea to spread things like PCI0
outside acpi-build.c. Why do you want to pass in the path
at all?
> ipmi_add_fwinfo(&sid->fwinfo, errp);
> }
>
> --
> 2.7.4
next prev parent reply other threads:[~2016-05-12 7:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 19:45 [Qemu-devel] [PATCH 0/7] Fix PM SMBus and add IPMI over SMBus minyard
2016-05-11 19:46 ` [Qemu-devel] [PATCH 1/7] i2c: Fix the PM SMBus driver so it actually works correctly minyard
2016-05-11 19:46 ` [Qemu-devel] [PATCH 2/7] pm_smbus: Add the ability to force block transfer enable minyard
2016-05-11 19:46 ` [Qemu-devel] [PATCH 3/7] pc: Add the SMBus device to the ACPI tables minyard
2016-05-11 19:46 ` [Qemu-devel] [PATCH 4/7] ipmi: Add an SMBus IPMI interface minyard
2016-05-11 19:46 ` [Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling minyard
2016-05-12 7:30 ` Michael S. Tsirkin
2016-05-12 13:26 ` Corey Minyard
2016-05-12 13:33 ` Michael S. Tsirkin
2016-05-11 19:46 ` [Qemu-devel] [PATCH 6/7] ipmi: Fix SSIF ACPI handling to use the right CRS minyard
2016-05-12 7:33 ` Michael S. Tsirkin
2016-05-12 13:29 ` Corey Minyard
2016-05-12 13:39 ` Michael S. Tsirkin
2016-05-13 13:13 ` Corey Minyard
2016-05-11 19:46 ` [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device minyard
2016-05-12 7:36 ` Michael S. Tsirkin [this message]
2016-05-12 13:32 ` Corey Minyard
2016-05-12 13:35 ` Michael S. Tsirkin
2016-05-12 19:20 ` Corey Minyard
2016-05-12 19:34 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160512103501-mutt-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=cminyard@mvista.com \
--cc=imammedo@redhat.com \
--cc=minyard@acm.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).