From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49182) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0lAH-0000no-V2 for qemu-devel@nongnu.org; Thu, 12 May 2016 03:36:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0lAD-0000WR-Bl for qemu-devel@nongnu.org; Thu, 12 May 2016 03:36:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0lAD-0000WF-5D for qemu-devel@nongnu.org; Thu, 12 May 2016 03:36:05 -0400 Date: Thu, 12 May 2016 10:36:01 +0300 From: "Michael S. Tsirkin" Message-ID: <20160512103501-mutt-send-email-mst@redhat.com> References: <1462995966-1184-1-git-send-email-minyard@acm.org> <1462995966-1184-8-git-send-email-minyard@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1462995966-1184-8-git-send-email-minyard@acm.org> Subject: Re: [Qemu-devel] [PATCH 7/7] ipmi: Add ACPI to the SMBus IPMI device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: minyard@acm.org Cc: Igor Mammedov , Paolo Bonzini , qemu-devel@nongnu.org, Corey Minyard On Wed, May 11, 2016 at 02:46:06PM -0500, minyard@acm.org wrote: > From: Corey Minyard > > Signed-off-by: Corey Minyard > --- > hw/ipmi/smbus_ipmi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ipmi/smbus_ipmi.c b/hw/ipmi/smbus_ipmi.c > index 4e7203b..3a34aaf 100644 > --- a/hw/ipmi/smbus_ipmi.c > +++ b/hw/ipmi/smbus_ipmi.c > @@ -167,6 +167,7 @@ static void smbus_ipmi_realize(DeviceState *dev, Error **errp) > sid->fwinfo.base_address = sid->parent.i2c.address; > sid->fwinfo.memspace = IPMI_MEMSPACE_SMBUS; > sid->fwinfo.register_spacing = 1; > + sid->fwinfo.acpi_parent = "\\_SB.PCI0.SMB0"; I don't think it's a good idea to spread things like PCI0 outside acpi-build.c. Why do you want to pass in the path at all? > ipmi_add_fwinfo(&sid->fwinfo, errp); > } > > -- > 2.7.4