From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0su7-0007PM-KO for qemu-devel@nongnu.org; Thu, 12 May 2016 11:52:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0su6-00078o-7X for qemu-devel@nongnu.org; Thu, 12 May 2016 11:51:59 -0400 Date: Thu, 12 May 2016 16:51:44 +0100 From: "Daniel P. Berrange" Message-ID: <20160512155144.GG23500@redhat.com> Reply-To: "Daniel P. Berrange" References: <1463006384-7734-1-git-send-email-eblake@redhat.com> <1463006384-7734-10-git-send-email-eblake@redhat.com> <20160512074730.GA20947@redhat.com> <5734A392.4000804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5734A392.4000804@redhat.com> Subject: Re: [Qemu-devel] [PATCH v4 09/11] nbd: Add qemu-nbd -D for human-readable description List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: qemu-devel@nongnu.org, Kevin Wolf , pbonzini@redhat.com, alex@alex.org.uk, qemu-block@nongnu.org, Max Reitz On Thu, May 12, 2016 at 09:38:58AM -0600, Eric Blake wrote: > On 05/12/2016 01:47 AM, Daniel P. Berrange wrote: > > On Wed, May 11, 2016 at 04:39:42PM -0600, Eric Blake wrote: > >> The NBD protocol allows servers to advertise a human-readable > >> description alongside an export name during NBD_OPT_LIST. Add > >> an option to pass through the user's string to the NBD client. > >> > >> Doing this also makes it easier to test commit 200650d4, which > >> is the client counterpart of receiving the description. > >> > > >> -@item -x NAME, --export-name=NAME > >> +@item -x, --export-name=@var{name} > > > > Why this change - that reads as saying that '-x' doesn't take any value > > which is wrong IMHO > > It's consistent with other options-with-arguments in the same file, such as: > > @item -p, --port=@var{port} > @item -o, --offset=@var{offset} > @item -b, --bind=@var{iface} > @item -k, --socket=@var{path} > > etc. Basically, we want to use this common escape hatch (see 'ls > --help', for example): > > Mandatory arguments to long options are mandatory for short options too. Ah, I didn't realize it was standard practice todo that - i personally just historically include the arg value in both, but if QEMU doesn't that's ok - consistency is more important. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|