From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36040)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1b0qjt-0000ut-5e
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:33:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1b0qjo-0004Zj-SL
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:33:16 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34561)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1b0qjo-0004Ze-NF
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:33:12 -0400
Date: Thu, 12 May 2016 16:33:09 +0300
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20160512163249-mutt-send-email-mst@redhat.com>
References: <1462995966-1184-1-git-send-email-minyard@acm.org>
	<1462995966-1184-6-git-send-email-minyard@acm.org>
	<20160512101937-mutt-send-email-mst@redhat.com>
	<573484A1.9000105@mvista.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <573484A1.9000105@mvista.com>
Subject: Re: [Qemu-devel] [PATCH 5/7] acpi: Add I2c serial bus CRS handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Corey Minyard <cminyard@mvista.com>
Cc: minyard@acm.org, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org

On Thu, May 12, 2016 at 08:26:57AM -0500, Corey Minyard wrote:
> On 05/12/2016 02:30 AM, Michael S. Tsirkin wrote:
> 
> Thanks for the comments, all fixed.
> 
> >>  /**
> >>   * init_aml_allocator:
> >>   *
> >>@@ -327,6 +336,8 @@ Aml *aml_qword_memory(AmlDecode dec, AmlMinFixed min_fixed,
> >>  Aml *aml_dma(AmlDmaType typ, AmlDmaBusMaster bm, AmlTransferSize sz,
> >>               uint8_t channel);
> >>  Aml *aml_sleep(uint64_t msec);
> >>+Aml *aml_i2c_serial_bus_device(uint8_t flags, uint32_t con_speed,
> >Drop these two parameters until they are actually useful.
> 
> I'm not sure I follow here.  The address parameter is important, it's for
> the I2C address.  The top 8 bytes are reserved 0, but not the bottom.  The
> resource source parameter tells which I2C bus it's hooked to.

I mean flags and con_speed.

> >
> >>+                               uint16_t address, const char *resource_source);
> >>  /* Block AML object primitives */
> >>  Aml *aml_scope(const char *name_format, ...) GCC_FMT_ATTR(1, 2);
> >>-- 
> >>2.7.4